Fix T90637: Outliner: VSE context menu options are not working
AbandonedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Aug 12 2021, 8:13 PM.

Details

Reviewers

Richard Antalik (ISS)
Julian Eisel (Severin)
Nathan Craddock (natecraddock)

Maniphest Tasks

T90637: Outliner: VSE context menu options are not working

Summary

Some of the enums that indicate operations in the context menu are not
supported for some element types like TSE_SEQUENCE.

From the user's point of view, this looks like a bug since the buttom
is there.

Then populate the enum list dynamically depending on the type.

Also add some calls that were missing from the TSE_SEQUENCE type.
(WM_event_add_notifier and ED_undo_push).

Ref T90637

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 16386
Build 16386: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Aug 12 2021, 8:13 PM

Germano Cavalcante (mano-wii) created this revision.

Harbormaster completed remote builds in B16386: Diff 40645.Aug 12 2021, 8:14 PM

Use static variable

Harbormaster completed remote builds in B16387: Diff 40647.Aug 12 2021, 8:41 PM

Fix: reset the slot that indicates the end of the list

Harbormaster completed remote builds in B16389: Diff 40649.Aug 12 2021, 9:02 PM

I noticed that this may be part of the Context Menu improvements as mentioned at https://devtalk.blender.org/t/gsoc-2020-outliner-discussion-and-suggestions/13178
So adding @Nathan Craddock (natecraddock) as reviewer (in case of interest).

Committed different solution - rB0ed2df81cc38

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_outliner/

outliner_tools.c

79 lines

Diff 40645

View Options

source/blender/editors/space_outliner/outliner_tools.c

Fix T90637: Outliner: VSE context menu options are not workingAbandonedPublicActions