Details

Reviewers

Maniphest Tasks

T90646: Sequencer hangs after transforming strips

Commits

rB24a3446787d3: Fix T90646: VSE hangs when strips overlap

Summary

When all strips are selected and overlap is caused, this causes VSE to
hang in infinite loop, because such situation should never happen.

To prevent infinite loop, ensure, that strip overlap is not tested
against single overlapping strip itself.

Prevent overlap that can not be handled because of issue described above
by moving overlapping strip between channels.

Better solution would be to limit transformation of strips if this would cause overlap. Here it seems possible to check strip length, but this is limited internally in sequencer code, so such check is not reliable.
Alternative would be to build list of static points that can limit transformation range (similar to current snapping, but 2D), then check if any strip overlaps with any point and by how much.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Aug 13 2021, 11:54 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B16404: Diff 40670.Aug 13 2021, 11:54 AM

Looks OK, request to make this case more explicit, to make it clear it's exceptional.

Requesting changes but I trust these are straightforward with that an extra review iteration.

source/blender/sequencer/intern/strip_transform.c
319–327	While this is correct, I'd suggest to make this case more explicit. /* The result of transform is a self-intersecting strip, ideally this would never ... etc ...*/ if (SEQ_collection_has_strip(seq_other, strips_to_shuffle)) { CLOG_WARN(... warning ...); continue; }

This revision is now accepted and ready to land.Aug 13 2021, 2:15 PM