Page MenuHome

Fix T90638: Inconsistent object data behavior when link-duplicating collections.
AbandonedPublic

Authored by Philipp Oeser (lichtwerk) on Aug 13 2021, 1:07 PM.

Details

Summary

Duplicating collections in Linked mode doesn't maintain camera/speaker/
lattice object data, but duplicates it.

Caused rBad6cccf058d0: Refactor duplicate of data-blocks..

Since above commit, object duplication was called with other dupliflags
(USER_DUP_OBJECT was added), so checking if flags were plain 0 was not
working anymore to determine if object data should be linked. This wasnt
a problem for other object types since these have dedicated flags which
camera/speaker/lattice dont have (and these were _not_ set, so
duplication didnt happen there).

Now be permissive with the USER_DUP_OBJECT flag and still consider this
as fully linked in terms of object data.

Also remove check (early return above makes it redundant).

Diff Detail

Repository
rB Blender
Branch
T90638 (branched from master)
Build Status
Buildable 16406
Build 16406: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 13 2021, 1:07 PM
Philipp Oeser (lichtwerk) created this revision.
Philipp Oeser (lichtwerk) planned changes to this revision.Aug 13 2021, 4:34 PM

needs some more digging to really handle all possible duplication flags right

Will step down due to time constraints, think this goes much more quickly if @Bastien Montagne (mont29) handles this