Page MenuHome
Differential D12214

Fix: Material Library VX add-on cannot apply library materials to selected object
ClosedPublic
Actions

Authored by Iyad Ahmed (iyadahmed2001) on Aug 14 2021, 12:04 AM.

Details

Reviewers
Alfonso de Leon Serra (mackraken)
Bastien Montagne (mont29)
Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)
Maniphest Tasks
T89680: Material Library VX add-on cannot apply library materials to selected object
T90483: Materials Library VX error when Preview
T89740: Materials Library throws error when applying a material
Commits
rBA36671a4e21b2: Fix: Material Library VX add-on cannot apply library materials to selected…
Summary

Fix https://developer.blender.org/T90483, https://developer.blender.org/T89680

Diff Detail

Event Timeline

Iyad Ahmed (iyadahmed2001) requested review of this revision.Aug 14 2021, 12:04 AM
Iyad Ahmed (iyadahmed2001) created this revision.
Iyad Ahmed (iyadahmed2001) added tasks: T89740: Materials Library throws error when applying a material, T90483: Materials Library VX error when Preview, T89680: Material Library VX add-on cannot apply library materials to selected object.Aug 14 2021, 12:08 AM
Vyacheslav (hitrpr) awarded a token.Aug 14 2021, 2:23 AM
Iyad Ahmed (iyadahmed2001) added a reviewer: Alfonso de Leon Serra (mackraken).Aug 14 2021, 11:25 AM
Habib Gahbiche (zazizizou) removed a reviewer: Add-ons (BF-Blender).Aug 14 2021, 11:47 AM
Thomas Dinges (dingto) added subscribers: Brendon Murphy (meta-androcto), Campbell Barton (campbellbarton), Thomas Dinges (dingto).Aug 14 2021, 10:18 PM

@Campbell Barton (campbellbarton) @Brendon Murphy (meta-androcto) Hi, could you guys please take a look at this patch? Thanks! :)

Brecht Van Lommel (brecht) removed a subscriber: Add-ons (Community).Aug 15 2021, 6:56 PM
YAFU (YAFU) awarded a token.Aug 20 2021, 1:10 AM
Iyad Ahmed (iyadahmed2001) added a comment.Aug 21 2021, 7:27 AM

ping

Bastien Montagne (mont29) accepted this revision.Aug 31 2021, 10:02 AM
This revision is now accepted and ready to land.Aug 31 2021, 10:02 AM
Bastien Montagne (mont29) added a comment.Aug 31 2021, 10:03 AM

This is merely an update for API changes, LGTM, will commit, thanks.

Dalai Felinto (dfelinto) accepted this revision.EditedAug 31 2021, 10:04 AM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).

Patch is correct. Thanks for the contribution.

Campbell Barton (campbellbarton) accepted this revision.Aug 31 2021, 10:07 AM
Closed by commit rBA36671a4e21b2: Fix: Material Library VX add-on cannot apply library materials to selected… (authored by Iyad Ahmed (iyadahmed2001), committed by Bastien Montagne (mont29)). · Explain WhyAug 31 2021, 10:15 AM
This revision was automatically updated to reflect the committed changes.
Bastien Montagne (mont29) added a commit: rBA36671a4e21b2: Fix: Material Library VX add-on cannot apply library materials to selected….
Iyad Ahmed (iyadahmed2001) added a comment.Aug 31 2021, 10:55 AM
In D12214#321068, @Bastien Montagne (mont29) wrote:

This is merely an update for API changes, LGTM, will commit, thanks.

Awesome many thanks!

Iyad Ahmed (iyadahmed2001) added a comment.Aug 31 2021, 10:55 AM
In D12214#321070, @Dalai Felinto (dfelinto) wrote:

Patch is correct. Thanks for the contribution.

Np 🙏

Revision Contents
Changeset List

PathSize
materials_library_vx/
4 lines

Diff 40692

View Options

materials_library_vx/__init__.py

Loading...