Adds full frame implementation to Anti-Aliasing, Defocus, Denoise,
Despeckle, Dilate/Erode, Directional Blur, Filter, Inpaint and
Vector Blur nodes. The other nodes in "Filter" sub-menu are
submitted separately.
Part of T88150.
Details
Details
- Reviewers
Jeroen Bakker (jbakker) - Commits
- rB9d7cb5c4a115: Compositor: Full frame filter nodes
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- cmp-nodes-filter (branched from master)
- Build Status
Buildable 16451 Build 16451: arc lint + arc unit
Event Timeline
Comment Actions
Is it possible to remove the Glare node from this patch. and implement it when the scaling requirement is implemented. Check the glare node implementation in January 2012 (node_composite_glare) That also didn't need it.
| source/blender/compositor/intern/COM_MemoryBuffer.h | ||
|---|---|---|
| 303 | Name is confusing. release_ownership_buffer. | |
Comment Actions
- Revert "Compositor: Full frame Glare node"
- Rename release_buffer to release_ownership_buffer
Comment Actions
If you're using linux and arc tool. You can stack patches this makes it easier to track down dependencies.
arc diff --base arc:D.... if I am not mistaken.
| source/blender/compositor/operations/COM_DirectionalBlurOperation.cc | ||
|---|---|---|
| 171 | Patch might miss a dependency. /home/jeroen/blender-git/blender/source/blender/compositor/operations/COM_DirectionalBlurOperation.cc:171:12: error: ‘const class blender::compositor::MemoryBuffer’ has no member named ‘read_elem_bilinear’
171 | input->read_elem_bilinear(x, y, color_accum);
| ^~~~~~~~~~~~~~~~~~
/home/jeroen/blender-git/blender/source/blender/compositor/operations/COM_DirectionalBlurOperation.cc:188:14: error: ‘const class blender::compositor::MemoryBuffer’ has no member named ‘read_elem_bilinear’
188 | input->read_elem_bilinear(
| ^~~~~~~~~~~~~~~~~~ | |
Comment Actions
The dependency is now in master, I've merged and the problem should be solved now.
I'll ensure from now on patches are properly stacked before assigning reviewer by checking "arc patch" myself.