Differential D12230
Fix T90651: camera reconstruction crash without scene camera Authored by Philipp Oeser (lichtwerk) on Aug 16 2021, 5:39 PM.
Details
This was working differently in 2.79, tried tracking this down and it This would not only crash without an active scene camera, but would also So select id depends on corresponding camera, remove the dependency on
Diff Detail
Event TimelineComment Actions To me the change looks correct. Marking Dalai and Jeroen as blocking to give them a chance to review from the draw manager side. Comment Actions Nothin against a change. I recall that this was always flaky. So currently when selecting a track it belongs to the object and not the camera anymore. Remember a ticket when having multiple cameras the trackers were not selectable. D6360: Tracking: Selection Crash Would want to test drive this patch to see if there is unwanted behavior. Comment Actions It seems correct to me. The logic and the faulty assumptions in the original commit. I will let Jeroen have the final word if he wants to stress test it, but honestly I can't see this going bad. |