Fix wireframe overlay not blending over paint overlay correctly
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Aug 17 2021, 12:41 AM.

Details

Reviewers

Jeroen Bakker (jbakker)
Demeter Dzadik (Mets)

Commits

rB24c16f54571f: Fix wireframe overlay not blending over paint overlay correctly

Summary

When using wireframe opacity, the paint overlay needs to be drawn
before the wireframes in order to alpha blend correctly.
Sculpt overlays were also affected by this, so this commit refactors
this part of the code in case other overlays needs to be added in
the future.

Before:

After:

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Aug 17 2021, 12:41 AM

Pablo Dobarro (pablodp606) created this revision.

Harbormaster completed remote builds in B16454: Diff 40762.Aug 17 2021, 12:41 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Aug 17 2021, 12:41 AM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).

Pablo Dobarro (pablodp606) mentioned this in D12170: T73434: Improve Weight Paint Overlay Drawing..Aug 17 2021, 12:44 AM

Codewise seems ok, but would like to have some feedback from users as the lines are less clear with this patch.

Jeroen Bakker (jbakker) added a reviewer: Demeter Dzadik (Mets).Aug 17 2021, 8:03 AM

Jeroen Bakker (jbakker) added projects: Sculpt, Paint & Texture, EEVEE & Viewport.

Tested, seems good! Previous behaviour was very strange. I didn't use the wireframe opacity slider before so I didn't know about this, but apparently without this patch, reducing wireframe opacity would just blend from an orange wireframe into a white wireframe - as opposed to blending out the wireframe. Hence the less visibility on the before/after. So things definitely make more sense with the patch.
Now my only wish is that the "Show Wire" paint overlay option would use the same wireframe drawing method, but I guess that's a separate issue :)

This revision is now accepted and ready to land.Aug 17 2021, 12:30 PM

Closed by commit rB24c16f54571f: Fix wireframe overlay not blending over paint overlay correctly (authored by Pablo Dobarro (pablodp606)). · Explain WhyAug 17 2021, 11:57 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB24c16f54571f: Fix wireframe overlay not blending over paint overlay correctly.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

overlay/

overlay_engine.c

28 lines

Diff 40816

View Options

source/blender/draw/engines/overlay/overlay_engine.c

Fix wireframe overlay not blending over paint overlay correctlyClosedPublicActions