Page MenuHome

Cycles X: Write all passes on cancel
ClosedPublic

Authored by Sergey Sharybin (sergey) on Aug 17 2021, 3:21 PM.

Details

Summary

Makes it possible to cancel rendering and have current state of all
passes written to the render result, matching old behavior.

Diff Detail

Repository
rB Blender
Branch
cycles-x_cancel (branched from master)
Build Status
Buildable 16470
Build 16470: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Aug 17 2021, 3:21 PM
Sergey Sharybin (sergey) created this revision.
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/integrator/path_trace.cpp
158

Remove ann.

This revision is now accepted and ready to land.Aug 17 2021, 3:31 PM
This revision was automatically updated to reflect the committed changes.

Noticed some issue with the viewport render, minor thing though: no need to run_wait_for_work if cancel has been requested (otherwise the loop becomes infinite). Hope you don't mind this being solved directly without another review iteration :)