Page MenuHome
Differential D12246

Cycles X: Write all passes on cancel
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Aug 17 2021, 3:21 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBb64cd94cd25f: Cycles X: Write all passes on cancel
Summary

Makes it possible to cancel rendering and have current state of all
passes written to the render result, matching old behavior.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Aug 17 2021, 3:21 PM
Sergey Sharybin (sergey) created this revision.
Harbormaster completed remote builds in B16470: Diff 40782.Aug 17 2021, 3:21 PM
Sergey Sharybin (sergey) mentioned this in D12039: Cycles X: Use GPUDisplay for non-interactive render.Aug 17 2021, 3:26 PM
Brecht Van Lommel (brecht) accepted this revision.Aug 17 2021, 3:31 PM
Brecht Van Lommel (brecht) added inline comments.
intern/cycles/integrator/path_trace.cpp
158

Remove ann.

This revision is now accepted and ready to land.Aug 17 2021, 3:31 PM
Closed by commit rBb64cd94cd25f: Cycles X: Write all passes on cancel (authored by Sergey Sharybin (sergey)). · Explain WhyAug 17 2021, 3:43 PM
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rBb64cd94cd25f: Cycles X: Write all passes on cancel.
Sergey Sharybin (sergey) added a comment.Aug 17 2021, 3:43 PM

Noticed some issue with the viewport render, minor thing though: no need to run_wait_for_work if cancel has been requested (otherwise the loop becomes infinite). Hope you don't mind this being solved directly without another review iteration :)

Revision Contents
Changeset List

PathSize
intern/
cycles/
integrator/
11 lines
9 lines
13 lines
render/
22 lines

Diff 40789

View Options

intern/cycles/integrator/path_trace.cpp

Loading...
View Options

intern/cycles/integrator/render_scheduler.h

Loading...
View Options

intern/cycles/integrator/render_scheduler.cpp

Loading...
View Options

intern/cycles/render/session.cpp

Loading...