Page MenuHome

Added more Geometry Node tests
ClosedPublic

Authored by Himanshi Kalra (calra) on Aug 17 2021, 9:42 PM.

Details

Summary
  • Attributes
  • Utilities
  • Volume

Extract the folder to lib\tests\modeling


It contains around 34 new tests.

  • attribute clamp + other attribute nodes
  • Curve Primitive nodes
  • Mesh Primitive nodes
  • delete geometry
  • convex hull
  • subdivision surface
  • boolean intersect
  • boolean diff
  • boolean union [Removed]
  • volume to mesh

Diff Detail

Repository
rB Blender
Branch
gn_test (branched from master)
Build Status
Buildable 16500
Build 16500: arc lint + arc unit

Event Timeline

Himanshi Kalra (calra) requested review of this revision.Aug 17 2021, 9:42 PM
Himanshi Kalra (calra) created this revision.
Himanshi Kalra (calra) planned changes to this revision.Aug 17 2021, 10:16 PM

Adding more Attribute tests.
The above zip file can be tested in its current state.

Himanshi Kalra (calra) edited the summary of this revision. (Show Details)
  • Fix Typo
  • Merge branch 'master' into gn_test
Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Aug 18 2021, 4:15 PM
  • Added tests for primitives
Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Aug 19 2021, 10:03 AM
Himanshi Kalra (calra) retitled this revision from Added categories for geometry node tests to Added more Geometry Node tests.Aug 19 2021, 10:07 AM
Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Aug 19 2021, 1:12 PM

Looks quite good, thanks. Only the geo_node_mesh_test_boolean_union test is failing for me. It seems like there might be some randomness involved in the code, hard to say. Can you reproduce that.
Note the changing vertex order in the spreadsheet in the video below.

No, can't reproduce. I see, its swapping 6 and 7 Y coordinates for you, they remain same here on Windows.

gn_test is a local branch on your repository right? In case the description becomes the commit message, no need to mention 'merge master into gn_test'.

Some tests are failing depending on the build config, is that expected?

building with make full (release):

The following tests FAILED:
	 73 - geo_node_attributes_test_attribute_mix (Failed)
	110 - geo_node_mesh_test_boolean_union (Failed)

using make (debug) :

The following tests FAILED:
	 73 - geo_node_attributes_test_attribute_mix (Failed)
	110 - geo_node_mesh_test_boolean_union (Failed)

with make lite (release):

The following tests FAILED:
	 38 - geo_node_attributes_test_attribute_color_ramp (Failed)
	 39 - geo_node_attributes_test_attribute_curve_map (Failed)
	 41 - geo_node_attributes_test_attribute_mix (Failed)
	 42 - geo_node_attributes_test_attribute_proximity (Failed)
	 44 - geo_node_attributes_test_attribute_sample_texture (Failed)
	 64 - geo_node_geometry_test_convex_hull (Failed)
	 76 - geo_node_mesh_test_boolean_diff (Failed)
	 77 - geo_node_mesh_test_boolean_intersect (Failed)
	 78 - geo_node_mesh_test_boolean_union (Failed)
	 80 - geo_node_mesh_test_subdivide (Failed)
	 81 - geo_node_mesh_test_subdivision_surface (Failed)
	 87 - geo_node_volume_test_volume_to_mesh (Failed)

Yes, thanks for the heads up. Wasn't planning on using the same description as commit message.

I have updated the blend files so that Attribute nodes don't fail on Lite. They were failing because I was using Subdivide and Subdivision Surface Nodes in my test files.
Attribute Mix and Boolean Union don't fail for me. I am on a Debug build.
Rest of them are expected to fail on Lite, as it compiled without these libraries:

  • Boolean - GMP
  • Convex Hull - Bullet
  • Subdivide - OpenSubDiv
  • Subdivision Surface - OpenSubDiv
  • Volume - OpenVDB
Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Aug 20 2021, 11:05 AM

@Habib Gahbiche (zazizizou) Attribute Mix is failing for you because I use Point Distribute + Rotation, see T90556 I will update that as well... hopefully the issue gets fixed properly. It was one of my favorite tests.

  • Merge branch 'master' into gn_test
  • Added vector category for vector tests
Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Aug 20 2021, 1:17 PM

Generally, tests look fine to me. But there are still a few tests failing for me:

The following tests FAILED:
	 75 - geo_node_attributes_test_attribute_mix (Failed)
	113 - geo_node_mesh_test_boolean_union (Failed)

Note that you can always run tests on all platforms using the buildbot to check for failing tests.

Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Aug 23 2021, 11:05 AM
  • Removed Boolean union
  • Updated attribute mix to not use Point Distribute.

All tests succeed for me now.

All tests are passing for me as well

This revision is now accepted and ready to land.Aug 23 2021, 11:10 PM