Page MenuHome

Fix T90772: Image Editor not sampling color from the the currently selected pass
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Aug 19 2021, 3:31 PM.

Details

Summary

Caused by rBebaa3fcedd23: Fix T84398: Multiview images show only one view..

I dont quite follow above commit, seems this assumed an ImageUser's
multi_index is only used for Multiview/Stereo? This is not the case,
multi_index also stores the index for layer/pass combination.

If we call both BKE_image_multilayer_index and BKE_image_multiview_index
(even though this is not appropriate/needed for multilayer images?), we
might end up overwriting multi_index again.

There might be a better solution for this (as I said, I might have
gotten the intention behind rBebaa3fcedd23 wrong).

note: looking at this I was also wondering why we update the ImageUser
in image-buffer-aquiring funnctions [and not from the UI, e.g.
template_image_layers, but that is a whole different story I guess, see
comment in T90772 as well]

Diff Detail

Repository
rB Blender
Branch
T90772 (branched from master)
Build Status
Buildable 16527
Build 16527: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 19 2021, 3:31 PM
Philipp Oeser (lichtwerk) created this revision.

note: (since this reverts part of rBebaa3fcedd23) I made sure T84398 is still fixed with this.

Patch is fine. Would be nice to have a function that does this for you. I assume that there are more placed where this is done.

This revision is now accepted and ready to land.Aug 23 2021, 1:17 PM