Page MenuHome
Differential D12272

Fix T90231: Create download page for each patch/branch
AbandonedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Aug 19 2021, 6:01 PM.

Details

Reviewers
James Monteath (jmonteath)
Maniphest Tasks
T90231: Create download page for each patch/branch.
Summary

This supports sub-pages for specific branches or patches. This way developers can pass a link around that shows only the relevant branches.

This patch includes:

  • Change page header when looking at specific branch/patch
  • Add link to sub-page in the patch/branch builds
  • Link to go back to All Patches/Branches

UI adjustments and design done with @Pablo Vazquez (pablovazquez) .
. . .

Note, this requires D12271

Diff Detail

Event Timeline

Dalai Felinto (dfelinto) requested review of this revision.Aug 19 2021, 6:01 PM
Dalai Felinto (dfelinto) created this revision.

Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Aug 19 2021, 6:03 PM
Dalai Felinto (dfelinto) added a task: T90231: Create download page for each patch/branch..
Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Aug 19 2021, 6:06 PM
Dalai Felinto (dfelinto) added a subscriber: Pablo Vazquez (pablovazquez).
Jacques Lucke (JacquesLucke) awarded a token.Aug 19 2021, 6:11 PM
Dalai Felinto (dfelinto) updated this revision to Diff 40901.Aug 20 2021, 11:36 AM

Rebased on latest D12271.

Dalai Felinto (dfelinto) added a reviewer: James Monteath (jmonteath).Aug 20 2021, 2:45 PM
James Monteath (jmonteath) added a comment.EditedAug 23 2021, 5:26 PM

Can you create a feature/download_patch branch from develop for this patch in the blender-buildbot-www project ?
I would need to run tests on the changes.

No changes should be done directly in develop or master that will be used for more testing and deployment.

Dalai Felinto (dfelinto) added a comment.Aug 24 2021, 9:47 AM
In D12272#319110, @James Monteath (jmonteath) wrote:

Can you create a feature/download_patch branch from develop for this patch in the blender-buildbot-www project ?
I would need to run tests on the changes.

No changes should be done directly in develop or master that will be used for more testing and deployment.

Done. I included all three patches (D12270, D12271 and D12272) in the branch,

Dalai Felinto (dfelinto) mentioned this in rBBW9acbca8d9025: Fix T90231: Create download page for each patch/branch.Aug 24 2021, 1:23 PM
James Monteath (jmonteath) added a comment.Aug 30 2021, 4:20 PM

Pushed to UATEST
https://builder-uatest.blender.org/download/daily/

I added few builds so they can be tested for the specific branch or patch.

James Monteath (jmonteath) added a comment.Aug 31 2021, 8:54 AM

Switched DEVTEST and UATEST back to develop branch as there seems to have issues with showing archived builds.
They show correctly here.
https://builder-uatest.blender.org/download/experimental/archive/

Dalai Felinto (dfelinto) added a comment.Aug 31 2021, 10:42 AM

I fixed the archive issue on feature/download_patch.

Dalai Felinto (dfelinto) updated this revision to Diff 41256.EditedAug 31 2021, 10:45 AM

There was a bug in the code that prevented archived builds from showing up. This commit fix this bug.

In the future if we want we can have per-branch/patch archive link. But for now let's have one big archive for simplicity sake (of the patch).

Dalai Felinto (dfelinto) mentioned this in rBBW5581d54402ff: Fix T90231: Create download page for each patch/branch.Aug 31 2021, 10:47 AM
James Monteath (jmonteath) added a comment.Aug 31 2021, 2:52 PM

Pushed fix to UATEST ready for tests.

If this is good, we can push to PROD.

Dalai Felinto (dfelinto) added a comment.Aug 31 2021, 2:59 PM

I'm doing some final tests. Will let you know

Dalai Felinto (dfelinto) mentioned this in rBBW2561c0edfbac: Fix T90231: Create download page for each patch/branch.Sep 1 2021, 10:03 AM
Dalai Felinto (dfelinto) mentioned this in rBBW84a52c36bf93: Fix T90231: Create download page for each patch/branch.Sep 1 2021, 10:07 AM
Dalai Felinto (dfelinto) updated this revision to Diff 41306.Sep 1 2021, 10:07 AM

Final fix (tm) for archive and downloads.

Dalai Felinto (dfelinto) added a comment.Sep 1 2021, 10:08 AM

@James Monteath (jmonteath) I pushed the branch with the latest patches. It is all good in my local tests. Ready to test UATEST

James Monteath (jmonteath) added a comment.Sep 1 2021, 7:33 PM

Pushed to UATEST.

Dalai Felinto (dfelinto) added a comment.Sep 2 2021, 9:26 AM

Working like a charm in UATEST, thanks.

James Monteath (jmonteath) added a comment.Sep 6 2021, 5:18 PM

Deployed to PROD

Dalai Felinto (dfelinto) abandoned this revision.Sep 6 2021, 5:46 PM

Revision Contents
Changeset List

PathSize
source/
6 lines
24 lines
15 lines
13 lines
templates/
10 lines
16 lines
webroot/
assets/
css/
3 lines

Diff 40901

View Options

source/Build.php

Loading...
View Options

source/BuildsDirectoryLister.php

Loading...
View Options

source/BuildsRenderer.php

Loading...
View Options

source/rules.php

Loading...
View Options

source/templates/footer.php

Loading...
View Options

source/templates/header.php

Loading...
View Options

webroot/assets/css/main.css

Loading...