Page MenuHome
Differential D12273

Using relative threshold for floats in mesh comparison
ClosedPublic
Actions

Authored by Himanshi Kalra (calra) on Aug 19 2021, 9:11 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rB875c2ea5b5ee: Using relative threshold for floats in mesh comparison
Summary

Changes the threshold comparison from absolute to relative.
Removes threshold for MLoopCol comparison.

Merge branch 'master' into threshold

Diff Detail

Repository
rB Blender
Branch
threshold (branched from master)
Build Status
Buildable 16580
Build 16580: arc lint + arc unit

Event Timeline

Himanshi Kalra (calra) requested review of this revision.Aug 19 2021, 9:11 PM
Himanshi Kalra (calra) created this revision.
Harbormaster completed remote builds in B16530: Diff 40890.Aug 19 2021, 9:11 PM
Himanshi Kalra (calra) added a reviewer: Jacques Lucke (JacquesLucke).Aug 19 2021, 9:14 PM
Himanshi Kalra (calra) updated this revision to Diff 40983.Aug 23 2021, 1:37 PM
  • Move threshold compare function near other functions
  • Merge branch 'master' into threshold
Harbormaster completed remote builds in B16560: Diff 40983.Aug 23 2021, 1:37 PM
Jacques Lucke (JacquesLucke) added inline comments.Aug 23 2021, 1:47 PM
source/blender/blenlib/intern/math_base_inline.c
659

Don't use else-after-return (https://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html)

Himanshi Kalra (calra) updated this revision to Diff 40984.Aug 23 2021, 1:48 PM
  • make format
Harbormaster completed remote builds in B16561: Diff 40984.Aug 23 2021, 1:48 PM
Himanshi Kalra (calra) updated this revision to Diff 40987.Aug 23 2021, 2:19 PM
  • Clang-tidy: Remove extra else after return
Harbormaster completed remote builds in B16563: Diff 40987.Aug 23 2021, 2:19 PM
Jacques Lucke (JacquesLucke) accepted this revision.Aug 23 2021, 4:58 PM

Please still update the comment, otherwise this looks good to me.

source/blender/blenkernel/intern/mesh.c
468–469

unnecessary newline

469

Use a loop that iterates from 0 to 2.

source/blender/blenlib/intern/math_base_inline.c
654

There is not really a danger of dividing by zero here, because there is no division in this function.
I suggest Avoid letting the threshold get too small just because the values happen to be close to zero.

This revision is now accepted and ready to land.Aug 23 2021, 4:58 PM
Himanshi Kalra (calra) updated this revision to Diff 41019.Aug 23 2021, 9:11 PM
Himanshi Kalra (calra) marked 4 inline comments as done.
  • Addressed comments
Harbormaster completed remote builds in B16580: Diff 41019.Aug 23 2021, 9:12 PM
Closed by commit rB875c2ea5b5ee: Using relative threshold for floats in mesh comparison (authored by Himanshi Kalra (calra)). · Explain WhyAug 23 2021, 9:23 PM
This revision was automatically updated to reflect the committed changes.
Himanshi Kalra (calra) added a commit: rB875c2ea5b5ee: Using relative threshold for floats in mesh comparison.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
26 lines
blenlib/
3 lines
intern/
12 lines

Diff 41019

View Options

source/blender/blenkernel/intern/mesh.c

Loading...
View Options

source/blender/blenlib/BLI_math_base.h

Loading...
View Options

source/blender/blenlib/intern/math_base_inline.c

Loading...