Page MenuHome
Differential D12287

Make knife drawing anti aliased (Monkey work based on D11333)
Needs RevisionPublic
Actions

Authored by Urko (urko3d) on Aug 21 2021, 11:13 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Commits
rB96027b2d15b7: Make knife drawing anti aliased (Monkey work based on D11333)
Summary

Knife tool.

Make the drawing anti aliased and consistent by using
3D_POLYLINE/3D_POINT shaders, and making sure alpha
blending is on.

Monkey work based on D11333
done by Anthony Edlin (krash)

Diff Detail

Repository
rB Blender

Event Timeline

Urko (urko3d) requested review of this revision.Aug 21 2021, 11:13 PM
Urko (urko3d) created this revision.
Iyad Ahmed (iyadahmed2001) awarded a token.Aug 22 2021, 11:08 PM
Urko (urko3d) added a project: EEVEE & Viewport.Aug 23 2021, 10:39 AM
Jeroen Bakker (jbakker) requested changes to this revision.Aug 23 2021, 1:12 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/mesh/editmesh_knife.c
366

This line doesn't do anything
Uniform color is overwritten before any draw call.

370

Remove commented out code.

414

This line doesn't do anything
Uniform color is overwritten before any draw call.

417

Remove commented out code.

491

This line doesn't do anything
Uniform color is overwritten before any draw call.

543

In /* Reset default */ section I miss the reset to GPU_BLEND_NONE.

This revision now requires changes to proceed.Aug 23 2021, 1:12 PM
Antonio Javier Torralba Moreno (corpse) awarded a token.Aug 23 2021, 10:06 PM
Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Aug 24 2021, 9:24 AM
Urko (urko3d) updated this revision to Diff 41048.Aug 24 2021, 10:21 AM

Updated the code.
Removed uniform color useless lines, comments and
add reset to GPU_BLEND_NONE in /* Reset default */ section

Urko (urko3d) marked 6 inline comments as done.Aug 24 2021, 10:28 PM
Jeroen Bakker (jbakker) accepted this revision.Aug 25 2021, 2:49 PM
This revision is now accepted and ready to land.Aug 25 2021, 2:49 PM
Raimund Klink (Raimund58) added a subscriber: Raimund Klink (Raimund58).Sep 21 2021, 1:44 PM
Closed by commit rB96027b2d15b7: Make knife drawing anti aliased (Monkey work based on D11333) (authored by Kulchynskiy Yuriy (urko), committed by Jeroen Bakker (jbakker)). · Explain WhySep 21 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB96027b2d15b7: Make knife drawing anti aliased (Monkey work based on D11333).
Jeroen Bakker (jbakker) added a reverting change: rB7633548d60cc: Revert "Make knife drawing anti aliased (Monkey work based on D11333)".Sep 22 2021, 1:50 PM
Jeroen Bakker (jbakker) reopened this revision.Sep 22 2021, 1:51 PM

This patch doesn't work in debug mode. There are several asserts that needs to be solved.

This revision is now accepted and ready to land.Sep 22 2021, 1:51 PM
Jeroen Bakker (jbakker) requested changes to this revision.Sep 22 2021, 1:51 PM
This revision now requires changes to proceed.Sep 22 2021, 1:51 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
52 lines

Diff 40941

View Options

source/blender/editors/mesh/editmesh_knife.c

Loading...