Page MenuHome

UI: Movie Clip: Cleanup Proxy Settings
Needs ReviewPublic

Authored by Aaron Carlisle (Blendify) on Aug 23 2021, 6:57 AM.

Details

Summary

The goal of this patch is to make the UI closely match the Proxy settings for the Video Sequencer

  • Use the ampersand instead of slash
  • Use split layout resulting in a more compact layout
  • Move the preview size to clip display
  • Adjust the clip display properties to be a bit more descriptive
BeforeAfter

Note the panel does need to be a bit wider to accommodate the labels without cutting them off but I think this is an acceptable trade-off for the cleaner look.
Also, this tradeoff could be fixed with a solution similar to D12440, the properties would have to be refactored to enums first..

Diff Detail

Repository
rB Blender
Branch
clip_ui_proxy (branched from master)
Build Status
Buildable 16554
Build 16554: arc lint + arc unit

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Aug 23 2021, 6:57 AM
Aaron Carlisle (Blendify) created this revision.
  • I'm honestly not sure the resolution buttons work better. The text will be cutoff by default and unless the panel is very wide, at which point it starts taking up too much space from everything else. And I don't really see D12440 as a solution here, since I'm not sure I agree that dynamic behavior is really what we want here.
  • Also, it looks like the buttons are not deactivated if the checkbox in the panel header is turned off?
  • I see you added "Clip" as well. Do the settings only apply to the selected/active clip?
  • "Directory" is a confusing name for a check-box. It doesn't enable "Directory", it enables custom proxies, right? I'd suggest sticking to labeling the button with what it does.

I'm honestly not sure the resolution buttons work better.

I agree that this point of the patch is the weakest, correctly there are no user interface guidelines for large labels.
For example, we could say if a label is more than 20 characters it should be written on its own line.

Also, it looks like the buttons are not deactivated if the checkbox in the panel header is turned off?

Noted as being something that will need to be updated with the patch.

"Directory" is a confusing name for a check-box. It doesn't enable "Directory", it enables custom proxies, right? I'd suggest sticking to labeling the button with what it does.

This might be confusing since the movie clip editor does not yet support custom proxies as a file but support can be added for this in the future. I still find it nice to keep the layout the same as the Video Sequencer.

I see you added "Clip" as well. Do the settings only apply to the selected/active clip?

Yes, they only apply to the active clip. This addition also matches the proxy settings layout in the Video Sequencer.

release/scripts/startup/bl_ui/space_clip.py
1130

Make the whole layout active based on header checkbox.