Page MenuHome
Differential D12300

NLA: shortcut to rename active strip
ClosedPublic
Actions

Authored by RedMser (RedMser) on Aug 23 2021, 2:37 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Brad Clark (RiggingDojo)
Commits
rB150f42e6d3a1: NLA: shortcut to rename active strip
Summary

NLA: shortcut to rename active strip

This extends the global F2 rename panel for the NLA editor.


Diff Detail

Repository
rB Blender
Branch
rename-nla-strips (branched from master)
Build Status
Buildable 16565
Build 16565: arc lint + arc unit

Event Timeline

RedMser (RedMser) requested review of this revision.Aug 23 2021, 2:37 PM
RedMser (RedMser) created this revision.
Harbormaster completed remote builds in B16565: Diff 40989.Aug 23 2021, 2:37 PM
RedMser (RedMser) added a parent revision: D12298: Markers: improve rename operator and shortcut.Aug 23 2021, 2:38 PM
RedMser (RedMser) updated this revision to Diff 40995.Aug 23 2021, 2:49 PM

Add menu item for the rename panel.

Harbormaster completed remote builds in B16569: Diff 40995.Aug 23 2021, 2:49 PM
RedMser (RedMser) edited the summary of this revision. (Show Details)Aug 23 2021, 2:51 PM
RedMser (RedMser) planned changes to this revision.Sep 27 2021, 2:38 PM

Will update this diff according to changes in D12298

Brad Clark (RiggingDojo) awarded a token.Nov 9 2021, 5:59 AM
Brad Clark (RiggingDojo) added a subscriber: Brad Clark (RiggingDojo).Dec 7 2021, 8:06 AM
RedMser (RedMser) updated this revision to Diff 47022.Jan 13 2022, 2:22 PM

Simplify code, decouple from marker changes.

Harbormaster completed remote builds in B19962: Diff 47022.Jan 13 2022, 2:22 PM
RedMser (RedMser) edited the summary of this revision. (Show Details)Jan 13 2022, 2:23 PM
RedMser (RedMser) removed a parent revision: D12298: Markers: improve rename operator and shortcut.
Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Jan 13 2022, 10:23 PM
RedMser (RedMser) updated this revision to Diff 47819.Feb 1 2022, 2:55 PM
  • Rebase onto master.
  • Use list comprehension.
  • Move "rename" menu entry from edit menu to the context menu, to be consistent with other editors (such as node editor, 3D viewport).
Harbormaster completed remote builds in B20271: Diff 47819.Feb 1 2022, 2:55 PM
RedMser (RedMser) edited the summary of this revision. (Show Details)Feb 1 2022, 2:56 PM
RedMser (RedMser) removed reviewers: User Interface, Animation & Rigging.
Sybren A. Stüvel (sybren) accepted this revision.Feb 1 2022, 4:03 PM
Sybren A. Stüvel (sybren) added reviewers: Sybren A. Stüvel (sybren), Brad Clark (RiggingDojo).
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).

The code looks good to me. @Brad Clark (RiggingDojo) I'll leave it to you to give it a thorough test to see if you can break it ;-)

Brad Clark (RiggingDojo) accepted this revision.Feb 1 2022, 6:25 PM

Tested in a few different ways and tried to break it, looks good!! thank you!

This revision is now accepted and ready to land.Feb 1 2022, 6:25 PM
Closed by commit rB150f42e6d3a1: NLA: shortcut to rename active strip (authored by RedMser (RedMser), committed by Sybren A. Stüvel (sybren)). · Explain WhyFeb 4 2022, 4:39 PM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rB150f42e6d3a1: NLA: shortcut to rename active strip.

Revision Contents
Changeset List

PathSize
release/
scripts/
presets/
keyconfig/
keymap_data/
6 lines
startup/
bl_ui/
4 lines
102 lines

Diff 40989

View Options

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...
View Options

release/scripts/startup/bl_ui/space_time.py

Loading...
View Options

release/scripts/startup/bl_ui/space_topbar.py

Loading...