The posterize node limits the number of colors per channel.
This is useful to generate masks or to generate stylized images
Both the tiled and full-frame implementation are included in this patch
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- compositor-posterize (branched from master)
- Build Status
Buildable 16577 Build 16577: arc lint + arc unit
Event Timeline
Comment Actions
If steps mean levels or percents, it may be more intuitive to posterize as steps increase just plugging the node it's full posterize. If it's by number of colors it's fine then.
If possible make it more progressive for fine control.
If an artist want to give feedback, it's very welcomed. I wonder if it could be useful to make the steps a socket to posterize with masks.
| source/blender/compositor/operations/COM_ColorPosterizeOperation.cc | ||
|---|---|---|
| 55 | Better use BuffersIterator to do the whole loop inheriting from MultiThreadedOperation. See InvertOperation as an example. I started using MultiThreadedRowOperation on some operations, but later we decided to better use iterators. | |
Comment Actions
The code looks good to me, but wait for Jeroen to have a look too.
My opinion is an artist should decide if a new node functionality is useful enough to be a main node.
| source/blender/compositor/nodes/COM_ColorPosterizeNode.cc | ||
|---|---|---|
| 21 | Rename files to match UI name and class names? ColorPosterize -> Posterize | |
Comment Actions
Based on other compositing pipelines and image editors this is a standard operation so I don't see any reason not to include it. It's also nice that non technical users don't have to use math nodes. I still want to investigate making the step size a float to see if that might be more artist friendly.
| release/scripts/startup/nodeitems_builtins.py | ||
|---|---|---|
| 372 | This might better belong in the color menu | |
Comment Actions
LGTM. I can see it be useful for mask extractions, but in that specific case a math operation would be useful.
Comment Actions
So based on some experiments, I found using a float input to be much more customizable, I will update this catch where the steps is exposed as a float input.
Comment Actions
- Move node to color menu
- Convert steps to float & rename files to match node name
- Convert node property to socket
Comment Actions
I have made quite a few changes to both the node and UX by changing the steps to a float and exposing it as a socket.
Comment Actions
Yes, to me this is better for user, they can use masks and have more fine control.
- Run make format before committing.
| source/blender/compositor/nodes/COM_PosterizeNode.cc | ||
|---|---|---|
| 16 ↗ | (On Diff #41231) | 2021 |
| source/blender/compositor/operations/COM_PosterizeOperation.h | ||
| 47 ↗ | (On Diff #41231) | End comments with full stop. |