Page MenuHome

Fix issues with absolute time unit
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Aug 25 2021, 4:01 PM.

Details

Summary

I think there are the following issues with rB5fa6cdb77a98: Add unit for time stored in seconds:

  • it does not take preferred unit settings into account
  • if we introduce a PROP_UNIT_TIME_ABSOLUTE unit, shouldnt it be visible

to RNA as well?

  • seems like a double entry sneaked into that commit?

This is in preparation to use this for render time limit in cycles-x (if
a user decides to input this as minutes [or even hours]).

ref. T90701

Diff Detail

Repository
rB Blender
Branch
T90701_a (branched from master)
Build Status
Buildable 16616
Build 16616: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 25 2021, 4:01 PM
Philipp Oeser (lichtwerk) created this revision.
Brecht Van Lommel (brecht) requested changes to this revision.Aug 25 2021, 4:20 PM

I don't think this should take into account scene unit settings. This time is independent of the scene timeline. Always using adaptive units seems correct to me.

This revision now requires changes to proceed.Aug 25 2021, 4:20 PM
  • dont take preferred unit settings into account
This revision is now accepted and ready to land.Aug 25 2021, 5:05 PM
This revision was automatically updated to reflect the committed changes.