Fix issues with absolute time unit
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 25 2021, 4:01 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Jacques Lucke (JacquesLucke)
Brecht Van Lommel (brecht)

Maniphest Tasks

T90701: render time limit

Commits

rBec66b3ef9b02: Fix issues with absolute time unit

Summary

I think there are the following issues with rB5fa6cdb77a98: Add unit for time stored in seconds:

it does not take preferred unit settings into account
if we introduce a PROP_UNIT_TIME_ABSOLUTE unit, shouldnt it be visible

to RNA as well?

seems like a double entry sneaked into that commit?

This is in preparation to use this for render time limit in cycles-x (if
a user decides to input this as minutes [or even hours]).

ref. T90701

Diff Detail

Repository

rB Blender

Branch

T90701_a (branched from master)

Build Status

Buildable 16618
Build 16618: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 25 2021, 4:01 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B16616: Diff 41088.Aug 25 2021, 4:01 PM

Sergey Sharybin (sergey) accepted this revision.Aug 25 2021, 4:05 PM

Sergey Sharybin (sergey) added 1 blocking reviewer(s): Brecht Van Lommel (brecht).

I don't think this should take into account scene unit settings. This time is independent of the scene timeline. Always using adaptive units seems correct to me.

This revision now requires changes to proceed.Aug 25 2021, 4:20 PM

dont take preferred unit settings into account

Harbormaster completed remote builds in B16618: Diff 41093.Aug 25 2021, 4:55 PM

Brecht Van Lommel (brecht) accepted this revision.Aug 25 2021, 5:05 PM

This revision is now accepted and ready to land.Aug 25 2021, 5:05 PM

Closed by commit rBec66b3ef9b02: Fix issues with absolute time unit (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 26 2021, 11:06 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBec66b3ef9b02: Fix issues with absolute time unit.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_rna.c

3 lines

python/

intern/

bpy_props.c

1 line

Diff 41093

View Options

source/blender/makesrna/intern/rna_rna.c