Paths

Table of Contentst

Differential D12321

Fix T90907: RNA pointers for material slots are not unique across IDs
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 26 2021, 12:18 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Maniphest Tasks

T90907: Change "Link materials to the object or the object's data" on multiple objects

Commits

rB6845aad1a271: Fix T90907: RNA pointers for material slots are not unique across IDs

Summary

Caused by rB1a81d268a19f: Materials: support changing materials during evaluation.

This caused e.g. ALT-clicking the 'Link' button to not propagate to
other selected objects (same as the 'Copy To Selected' context menu
entry).

If these are not unique across IDs, checks in ui_selectcontext_begin()
or copy_to_selected_button() could fail.

Now offset by ID pointer.

thx @Jacques Lucke (JacquesLucke) for clarification on the POINTER_* macros (and why
not to use them)!

Diff Detail

Repository

rB Blender

Branch

T90907 (branched from master)

Build Status

Buildable 16626
Build 16626: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 26 2021, 12:18 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B16626: Diff 41112.Aug 26 2021, 12:18 PM

Philipp Oeser (lichtwerk) added a project: Core.Aug 26 2021, 12:19 PM

dont use POINTER_AS_INT on 64bit pointer

Harbormaster completed remote builds in B16628: Diff 41115.Aug 26 2021, 12:35 PM

I think this could should just not use the POINTER_* macros at all. Those are meant to be used when converting indices to pointers and back.

source/blender/makesrna/intern/rna_object.c
1330	This is still using `POINTER_AS_INT` on a pointer. This works by accident.

This revision now requires changes to proceed.Aug 26 2021, 12:51 PM

dont use POINTER_* macros at all here

Harbormaster completed remote builds in B16651: Diff 41151.Aug 27 2021, 9:19 AM

Philipp Oeser (lichtwerk) marked an inline comment as done.Aug 27 2021, 9:20 AM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) accepted this revision.Aug 27 2021, 10:47 AM

This revision is now accepted and ready to land.Aug 27 2021, 10:47 AM

Closed by commit rB6845aad1a271: Fix T90907: RNA pointers for material slots are not unique across IDs (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 27 2021, 11:07 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB6845aad1a271: Fix T90907: RNA pointers for material slots are not unique across IDs.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_buttons/

buttons_context.c

3 lines

makesrna/

intern/

rna_object.c

11 lines

Diff 41112

View Options

source/blender/editors/space_buttons/buttons_context.c