VSE: remove Strip user count
AcceptedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Aug 26 2021, 4:45 PM.

Details

Reviewers

Richard Antalik (ISS)

Summary

The Strip data type had a user count variable even if it couln't have
more than one user currently.

In addition to this, it also had a done varaible to handle writing and
reading data that had multiple users.

Remove both as they are not used or userful currently.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Aug 26 2021, 4:45 PM

Sebastian Parborg (zeddb) created this revision.

Richard Antalik (ISS) accepted this revision.Aug 27 2021, 2:52 AM

This revision is now accepted and ready to land.Aug 27 2021, 2:52 AM

Only now I noticed, that this will produce error in older blender versions error: negative users in strip and therefore this will cause some small-ish memory leak. I am not quite sure whether this would be a cause for concern though.

In D12325#320236, @Richard Antalik (ISS) wrote:

Only now I noticed, that this will produce error in older blender versions error: negative users in strip and therefore this will cause some small-ish memory leak. I am not quite sure whether this would be a cause for concern though.

Good catch!
I talked to Bastien about this and we said that I should discuss this further with the core module and see if they think this is acceptable.
However I'm going on vacation now, so this has to wait for two weeks or so.

@Sergey Sharybin (sergey) Do you have any objections to this?
I don't think that a small memory leak when opening the file in older versions is anything to worry about.