Page MenuHome

GPencil: Add buttons to move up and down vertex groups
ClosedPublic

Authored by Antonio Vazquez (antoniov) on Aug 26 2021, 7:47 PM.

Diff Detail

Repository
rB Blender
Branch
temp-vertexgroup-move (branched from master)
Build Status
Buildable 16643
Build 16643: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Aug 26 2021, 7:47 PM
Antonio Vazquez (antoniov) created this revision.
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/editors/object/object_vgroup.c
4088

It would be nice to have a comment here describing why the special case is necessary, like Grease pencil stores vertex groups separately for each stroke, so remap each stroke's weights separately.

4095

Don't think this dvert_tot > 0 check is necessary, since the while loop won't execute if it's condition is false before it starts.

For bonus points this could just be a for loop ;)

This revision is now accepted and ready to land.Aug 26 2021, 9:00 PM
  • Minor changes after review