Panel drag-collapse
AbandonedPublic
Actions

Authored by Julian Eisel (Severin) on Apr 12 2015, 9:09 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Summary

Panel drag-collapse

Adds a way to quickly open/close multiple panels by holding LMB and dragging over the desired panels

The decision if the panels are opened or closed is made based on the first Panel the user drags over. If it is closed, all panels he drags over are opened (including the first one) if it's opened, they get closed.

Again the basic idea comes from @Manu Järvinen (maxon) :P

Diff Detail

Event Timeline

Julian Eisel (Severin) updated this revision to Diff 3960.Apr 12 2015, 9:09 PM

Julian Eisel (Severin) retitled this revision from to Panel drag-collapse.

Julian Eisel (Severin) updated this object.

Julian Eisel (Severin) added a reviewer: Campbell Barton (campbellbarton).

Julian Eisel (Severin) set the repository for this revision to rB Blender.

Julian Eisel (Severin) added a project: User Interface.

Julian Eisel (Severin) added subscribers: Pablo Vazquez (pablovazquez), Jonathan Williamson (carter2422), Manu Järvinen (maxon), Sebastian Koenig (sebastian_k).

Manu Järvinen (maxon) awarded a token.Apr 13 2015, 10:42 AM

This is great! :)

Why Shift+LMB instead of the simple dragging that is in use in Outliner, for example?

Gif:

Generally good functionality.
Agree with Manu, shift isnt needed.
Prefer have this prepared for master, not very happy with multiple UI patches in gooseberry, especially since changes in this area so easily conflict.

This should be done via WM_event_add_ui_handler as with boolean drag toggle. see ui_but_drag_init

Having to store modal flags in the region - drag_collapse_flag, is bad code-smell.

This revision now requires changes to proceed.Apr 16 2015, 12:05 PM

Use LMB+Drag instead of Shift+LMB+Drag
Use modal handler
Get rid of bad code smells ;)

Mostly looks good, however its a bit unreliable since you can drag your mouse *over* a panel and skip it by accident - depending on redraw/mouse speed.

Check how I handled this for toggle-drag.ui_drag_toggle_set_xy_xy