In contrast to the Filebrowser, the Outliner (Blender File view) did not
distinguish icons for text-based formats (if they have a filepath this
can be done though).
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
| source/blender/editors/space_outliner/outliner_draw.c | ||
|---|---|---|
| 2632 | Seems like a nice place for a comment, I'm honestly not sure how a VDB file could end up being loaded as a text, for example. | |
| source/blender/editors/space_outliner/outliner_select.c | ||
| 1431 ↗ | (On Diff #41224) | Is there a reason to make this a special case and not put it in tree_element_activate? |
Comment Actions
Could you split the fix from the new feature (activating text on click)? Looking up the biggest area has always been kinda weak, I had multiple experienced users complain about this seemingly random behavior. But better to discuss that in a dedicated patch/task.
| source/blender/editors/space_outliner/outliner_draw.c | ||
|---|---|---|
| 2633 | Shouldn't ICON_FILE_TEXT be the default/fallback icon? | |
| source/blender/editors/space_outliner/outliner_select.c | ||
| 1433–1442 ↗ | (On Diff #41224) | This seems like a direct copy from editsource_text_edit()? Better put this into a function then. |
| source/blender/editors/space_outliner/outliner_draw.c | ||
|---|---|---|
| 2632 | Without filtering, the Text Editor can open all kinds of formats (.obj, ...) | |
Comment Actions
- split of activating into own patch
- change back default icon to script (since these can have no extension or not be saved -- and still think these are the most common)
Comment Actions
I'd personally still prefer ICON_FILE_TEXT as default icon, it's just the more general one. Now it shows the wrong icon if a non-script file is loaded but not saved.