FBX Import: skip invalid custom enum properties
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 31 2021, 9:44 AM.

Details

Reviewers

Maniphest Tasks

T81657: FBX Import error (enum with -1 value -- e.g. as done by the babylonjs exporter from 3dsmax)
T83501: Import Error FBX from 3ds Max
T86595: i can't import fbx because of python:Traceback
T91062: Failure to import this FBX (but Unity handles it well)

Commits

rBA770d08b71f6b: FBX Import: skip invalid custom enum properties
rBA2fe7db71710f: FBX Import: skip invalid custom enum properties
rBA4e30cfd30603: FBX Import: skip invalid custom enum properties

Summary

This was (correctly) asserting before, now handle this more gracefully
and just skip (and warn about this) a custom property that has an
invalid value set.

Seems there are a couple of exporters out there that do this wrong, I
think this tradeoff can be made though.

Fixes T91062, T81657, T83501, T86595

Diff Detail

Repository

rBA Blender Add-ons

Branch

fbx_invalid_enum_values (branched from master)

Build Status

Buildable 16709
Build 16709: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 31 2021, 9:44 AM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B16709: Diff 41252.Aug 31 2021, 9:44 AM

Philipp Oeser (lichtwerk) added projects: Pipeline, Assets & I/O, Add-ons (BF-Blender).Aug 31 2021, 9:44 AM

Philipp Oeser (lichtwerk) mentioned this in T91062: Failure to import this FBX (but Unity handles it well).Aug 31 2021, 9:53 AM

Please remember to also increase revision number of the version in the __init__.py file.

This revision is now accepted and ready to land.Aug 31 2021, 10:25 AM

Closed by commit rBA4e30cfd30603: FBX Import: skip invalid custom enum properties (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 31 2021, 10:51 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBA4e30cfd30603: FBX Import: skip invalid custom enum properties.

Philipp Oeser (lichtwerk) added a commit: rBA2fe7db71710f: FBX Import: skip invalid custom enum properties.Nov 23 2021, 10:07 AM

Philipp Oeser (lichtwerk) added a commit: rBA770d08b71f6b: FBX Import: skip invalid custom enum properties.Jan 18 2022, 11:08 AM

Revision Contents
Changeset List

Path

Size

io_scene_fbx/

import_fbx.py

6 lines

Diff 41252

View Options

io_scene_fbx/import_fbx.py

FBX Import: skip invalid custom enum propertiesClosedPublicActions