Page MenuHome

Fix T91060: GPencil Time Offset Modifier breaks evaluation time
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Aug 31 2021, 11:41 AM.

Details

Summary

Caused by rBf3bf87e5887c: GPencil: Small frame evaluation speed up improvement.

When using a GPencil Time Offset Modifier, the bGPDlayer>actframe can be
NULL. This can be determined though, but above optimization commit
skipped getting the active frame in this case entirely (with the
intention to only get it if framenumbers did not match).

Now also call BKE_gpencil_layer_frame_get() if actframe is NULL in order
to fetch a valid one if present.

Diff Detail

Repository
rB Blender
Branch
T91060 (branched from master)
Build Status
Buildable 16712
Build 16712: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 31 2021, 11:41 AM
Philipp Oeser (lichtwerk) created this revision.

Good job..yes, the actframewas null and need to run the function to get the frame from timeoffset modifier or the eval data would be wrong.

This revision is now accepted and ready to land.Aug 31 2021, 11:46 AM