/home/jacques/blender-git/blender/source/blender/nodes/composite/nodes/node_composite_defocus.cc:26:10: warning: inclusion of deprecated C++ header 'limits.h'; consider using 'climits' instead [modernize-deprecated-headers]
#include <limits.h>
         ^~~~~~~~~~
         <climits>
[988/2164] Building CXX object source/blender/nodes/CMakeFiles/bf_nodes.dir/composite/nodes/node_composite_image.cc.o
/home/jacques/blender-git/blender/source/blender/nodes/composite/nodes/node_composite_image.cc:225:1: warning: use 'using' instead of 'typedef' [modernize-use-using]
typedef struct RLayerUpdateData {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[1009/2164] Building CXX object source/blender/nodes/CMakeFiles/bf_nodes.dir/composite/nodes/node_composite_outputFile.cc.o
/home/jacques/blender-git/blender/source/blender/nodes/composite/nodes/node_composite_outputFile.cc:26:10: warning: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers]
#include <string.h>
         ^~~~~~~~~~
         <cstring>
[1035/2164] Building CXX object source/blender/nodes/CMakeFiles/bf_nodes.dir/composite/node_composite_util.cc.o
/home/jacques/blender-git/blender/source/blender/nodes/composite/node_composite_util.hh:53:6: warning: function 'cmp_node_poll_default' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
bool cmp_node_poll_default(struct bNodeType *ntype,
     ^
/home/jacques/blender-git/blender/source/blender/nodes/composite/node_composite_util.cc:26:6: note: the definition seen here
bool cmp_node_poll_default(bNodeType *UNUSED(ntype),
     ^
/home/jacques/blender-git/blender/source/blender/nodes/composite/node_composite_util.hh:53:6: note: differing parameters are named here: ('r_disabled_info'), in definition: ('r_disabled_hint')
bool cmp_node_poll_default(struct bNodeType *ntype,
     ^
[1036/2164] Building CXX object source/blender/nodes/CMakeFiles/bf_nodes.dir/composite/node_composite_tree.cc.o
/home/jacques/blender-git/blender/source/blender/nodes/composite/node_composite_tree.cc:24:10: warning: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]
#include <stdio.h>
         ^~~~~~~~~
         <cstdio>

Note, for the use 'using' instead of 'typedef' warning just remove the typedef alltogether.

Jeroen Bakker (jbakker) edited reviewers, added: Manuel Castilla (manzanilla); removed: Jeroen Bakker (jbakker).Sep 1 2021, 2:43 PM

clabg-tidy: fix includes
Address clang tidy warnings

Harbormaster completed remote builds in B16761: Diff 41341.Sep 1 2021, 9:29 PM

You didn't fix one warning, rename r_disabled_info -> r_disabled_hint and remove the UNUSED of the last commit:

warning: function 'cmp_node_poll_default' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
bool cmp_node_poll_default(struct bNodeType *UNUSED(ntype),
     ^
/home/lolme/bf/blender/source/blender/nodes/composite/node_composite_util.cc:26:6: note: the definition seen here
bool cmp_node_poll_default(bNodeType *UNUSED(ntype),
     ^
/home/lolme/bf/blender/source/blender/nodes/composite/node_composite_util.hh:53:6: note: differing parameters are named here: ('r_disabled_info'), in definition: ('r_disabled_hint')
bool cmp_node_poll_default(struct bNodeType *UNUSED(ntype),
     ^

You need to enable clang-format, run make format.

source/blender/nodes/composite/nodes/node_composite_image.cc
155–156	declare it as `eNodeSocketDatatype` instead of converting it later
source/blender/nodes/composite/nodes/node_composite_splitViewer.cc
41	No need to rename it to `data`, `iuser` is more descriptive. There are other cases like this, I'd rather keep the original name.