Page MenuHome
Differential D12370

Cycles X: Support GPUDisplay with tiled rendering
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Sep 1 2021, 5:14 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
William Leeson (leesonw)
Commits
rBb72c1e93247f: Cycles X: Support GPUDisplay with tiled rendering
Summary

Allocate GPUDisplay texture for the full frame size, and fill pixels
tile-by-tile as they come.

Will allow to use GPUDisplay for final render display from D12039
together with tiled rendering support from D12309.

Tested by applying on top of the D12309 and forcing tiles in the
viewport.

Diff Detail

Repository
rB Blender
Branch
cycles-x_tile_gpu_display_v2 (branched from master)
Build Status
Buildable 16757
Build 16757: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Sep 1 2021, 5:14 PM
Sergey Sharybin (sergey) created this revision.
Harbormaster completed remote builds in B16757: Diff 41327.Sep 1 2021, 5:14 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 1 2021, 8:58 PM
This revision is now accepted and ready to land.Sep 1 2021, 8:58 PM
Sergey Sharybin (sergey) added inline comments.Sep 2 2021, 12:35 PM
intern/cycles/integrator/path_trace.cpp
112

This is a bad modification: prevents redraw to happen as often as it should in viewport. I'll revert this change before commit and add explanation so we don't break things again.

Closed by commit rBb72c1e93247f: Cycles X: Support GPUDisplay with tiled rendering (authored by Sergey Sharybin (sergey)). · Explain WhySep 2 2021, 12:36 PM
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rBb72c1e93247f: Cycles X: Support GPUDisplay with tiled rendering.

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
6 lines
integrator/
9 lines
19 lines
13 lines
5 lines
31 lines
14 lines
20 lines
7 lines
7 lines
24 lines
kernel/
device/
gpu/
31 lines
render/
6 lines
7 lines
2 lines

Diff 41327

View Options

intern/cycles/blender/blender_gpu_display.cpp

Loading...
View Options

intern/cycles/integrator/pass_accessor.h

Loading...
View Options

intern/cycles/integrator/pass_accessor_cpu.cpp

Loading...
View Options

intern/cycles/integrator/pass_accessor_gpu.cpp

Loading...
View Options

intern/cycles/integrator/path_trace.h

Loading...
View Options

intern/cycles/integrator/path_trace.cpp

Loading...
View Options

intern/cycles/integrator/path_trace_work.h

Loading...
View Options

intern/cycles/integrator/path_trace_work.cpp

Loading...
View Options

intern/cycles/integrator/path_trace_work_cpu.cpp

Loading...
View Options

intern/cycles/integrator/path_trace_work_gpu.h

Loading...
View Options

intern/cycles/integrator/path_trace_work_gpu.cpp

Loading...
View Options

intern/cycles/kernel/device/gpu/kernel.h

Loading...
View Options

intern/cycles/render/gpu_display.h

Loading...
View Options

intern/cycles/render/gpu_display.cpp

Loading...
View Options

intern/cycles/render/session.cpp

Loading...