Geometry Nodes: Change Mesh Primitive Nodes to New Socket Format
ClosedPublic
Actions

Authored by Johnny Matthews (guitargeek) on Sep 1 2021, 5:54 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)
Hans Goudey (HooglyBoogly)

Summary

Change the remaining Mesh Primitive Nodes to New Socket Format

cube.
cylinder
grid
ico_sphere
line
uv_sphere

Diff Detail

Repository: rB Blender

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Sep 1 2021, 5:54 PM

Johnny Matthews (guitargeek) created this revision.

Looks good, the only thing I think I'd change is always keeping the socket definition at the top of the file. The layout and update functions could be added to the blender::nodes namespace in that case.

Rearrange the files so that the socket declarations are at the top.

Correct diff file

Hans Goudey (HooglyBoogly) mentioned this in rB0ccbf5069431: Cleanup: Convert geometry nodes socket list to use new API.Sep 2 2021, 5:55 AM

Hans Goudey (HooglyBoogly) accepted this revision.Sep 2 2021, 5:57 AM

Hans Goudey (HooglyBoogly) added a reviewer: Hans Goudey (HooglyBoogly).

This revision is now accepted and ready to land.Sep 2 2021, 5:57 AM

Closed with rB0ccbf5069431

Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.Sep 14 2021, 11:56 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_mesh_primitive_cylinder.cc

24 lines

node_geo_mesh_primitive_line.cc

28 lines

Diff 41333

View Options

source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cylinder.cc