Paths

Table of Contentst

Differential D12382

Fix T90120: Image Editor Paint cursor lost exiting texture paint mode
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 2 2021, 5:09 PM.

Tags

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T90120: Image editor Paint mode brush display bug

Summary

Caused by either rB465a9f65de76: Cleanup: remove window manager argument for paint cursor API or rB78017916f7c7: Fix error removing the image paint cursor.

Not sure if the above just exposed a bug/design flaw or if we are now
acting on the wrong cursor.

While there are probably better ways to do this [by letting
WM_paint_cursor_end() be a bit more selective/polling on what it kills],
we can also just do a "cleanup" pass after [using
ED_space_image_paint_update() to make sure the Image Editor is in the
right state].

Diff Detail

Repository

Branch

T90120 (branched from master)

Build Status

Buildable 16781
Build 16781: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 2 2021, 5:09 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B16781: Diff 41374.Sep 2 2021, 5:09 PM

Philipp Oeser (lichtwerk) added projects: Sculpt, Paint & Texture, User Interface.Sep 2 2021, 5:10 PM

Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Sep 3 2021, 9:05 AM

This will be disabling the cursor then re-enabling it.

Suggest to add a check in toggle_paint_cursor, only to disable the cursor if it's not used.

The part of ED_space_image_paint_update that checks if the paint cursor should show will have to be extracted into a separate function.

This revision now requires changes to proceed.Sep 3 2021, 12:53 PM

Will have to concentrate on triaging for a while (and step down).

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

2 lines

Diff 41374

source/blender/editors/sculpt_paint/paint_image.c

Loading...