Page MenuHome
Differential D12391

Fix Drivers Editor not hiding vertical part of cursor
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 3 2021, 3:53 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Jeroen Bakker (jbakker)
Maniphest Tasks
T91157: Drivers Editor : Frame indicator/controller & cursor problem
Commits
rB6f29801f1b69: Fix Drivers Editor not hiding vertical part of cursor
Summary

When "Show Cursor" is unchecked, the Drivers Editor would still display
the vertical line representing the cursor x.

Probably overseen in rB65072499c65a: Graph Editor: Allow "cursor x" to have fractional values when working with… (historically the vertical line
could represent either the current frame of the cursor X in drawing, but
this is now much more separate).

There is no point in seeing part of the cursor in the Drivers Editor if
this is disabled.

Also correct outdated comments.

ref. T91157

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 3 2021, 3:53 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B16808: Diff 41418.Sep 3 2021, 3:53 PM
Philipp Oeser (lichtwerk) added projects: Animation & Rigging, EEVEE & Viewport.Sep 3 2021, 3:54 PM
Philipp Oeser (lichtwerk) mentioned this in T91157: Drivers Editor : Frame indicator/controller & cursor problem.Sep 3 2021, 4:20 PM
Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Sybren A. Stüvel (sybren).Sep 6 2021, 11:23 AM

Drawing code seems fine. Would leave the approval of the functionality to the animation module.

Jeroen Bakker (jbakker) accepted this revision.Sep 6 2021, 11:23 AM
Philipp Oeser (lichtwerk) mentioned this in T89626: UI: Inconsistencies across animation editors.Sep 15 2021, 9:03 AM
Sybren A. Stüvel (sybren) accepted this revision.Sep 28 2021, 10:14 AM

I agree, it's weird that only part of the cursor would disappear when turning off Show Cursor.
Thanks for the fix!

This revision is now accepted and ready to land.Sep 28 2021, 10:14 AM
Closed by commit rB6f29801f1b69: Fix Drivers Editor not hiding vertical part of cursor (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 28 2021, 11:15 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB6f29801f1b69: Fix Drivers Editor not hiding vertical part of cursor.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_graph/
26 lines

Diff 42538

View Options

source/blender/editors/space_graph/space_graph.c

Loading...