Page MenuHome

Fix Drivers Editor showing playhead on the X Axis
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Sep 3 2021, 4:14 PM.

Details

Summary

Currently the Drivers Editor shows this (the blue thing can be dragged to change frame):

But the Drivers Editors X axis is the output of the driver [which can be further tweaked by the curve] not time(frame).
So it seems better to not mix them here, it is just confusing to have two different units on one axis.
Especially since what we really want to look at in X (the drivers output value) can be in a totally unrelated range compared to frames, so e.g. we might be interested in a drivers range from 0.0 to 1.0 and a framerange of 100 to 200, so putting this on one axis just does not make sense. Better to use a separate timeline for this.

Note 2.79 also did not do this.

ref. T91157

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 3 2021, 4:14 PM

Drawing side LGTM. Will let animation module decide on the UI side.

Philipp Oeser (lichtwerk) retitled this revision from Fix Drivers Editor showing frame scrubbing to Fix Drivers Editor showing playhead on the X Axis.
This revision is now accepted and ready to land.Sep 28 2021, 10:39 AM

'to from' Please seen inline comment

source/blender/editors/animation/time_scrub_ui.c
108

Should this read?...

/* Draw vertical line from the bottom of the current frame box to the bottom of the screen.