Page MenuHome
Differential D12394

Cycles X: improve denoising features for volumes
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Sep 3 2021, 6:41 PM.
Tags
None
Subscribers
None
Tokens
"Love" token, awarded by Raimund58."Love" token, awarded by dingto."Love" token, awarded by MasterNurmi."Love" token, awarded by ace_dragon."Love" token, awarded by Alaska."Love" token, awarded by HEYPictures.

Details

Reviewers
Sergey Sharybin (sergey)
William Leeson (leesonw)
Commits
rBd18a3b728b43: Cycles X: improve denoising features for volumes
Summary
  • Write accumulate volume albedo along ray
  • Write view direction as normal
  • Fix incorrect write of surface albedo after volume scatter

Diff Detail

Repository
rB Blender
Branch
denoise-volume (branched from master)
Build Status
Buildable 16811
Build 16811: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Sep 3 2021, 6:41 PM
Brecht Van Lommel (brecht) created this revision.
Harbormaster completed remote builds in B16811: Diff 41427.Sep 3 2021, 6:41 PM
Brecht Van Lommel (brecht) added a comment.Sep 3 2021, 6:44 PM

For some files there is no real difference, but in some like these it does help to reduce noise or preserve detail around boundaries better.

OldNewAlbedo Pass
denoise_volume test
wdas_cloud
HEYPictures (HEYPictures) awarded a token.Sep 3 2021, 11:19 PM
Alaska (Alaska) awarded a token.Sep 3 2021, 11:47 PM
Adam Friesen (ace_dragon) awarded a token.Sep 4 2021, 1:26 AM
Super Secret Goblin Prince (MasterNurmi) awarded a token.Sep 4 2021, 12:21 PM
Thomas Dinges (dingto) awarded a token.Sep 4 2021, 6:54 PM
Raimund Klink (Raimund58) awarded a token.Sep 5 2021, 10:47 PM
Sergey Sharybin (sergey) accepted this revision.Sep 6 2021, 11:41 AM
This revision is now accepted and ready to land.Sep 6 2021, 11:41 AM
Closed by commit rBd18a3b728b43: Cycles X: improve denoising features for volumes (authored by Brecht Van Lommel (brecht)). · Explain WhySep 6 2021, 2:25 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBd18a3b728b43: Cycles X: improve denoising features for volumes.

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
integrator/
2 lines
40 lines
27 lines

Diff 41427

View Options

intern/cycles/kernel/integrator/integrator_shade_surface.h

Loading...
View Options

intern/cycles/kernel/integrator/integrator_shade_volume.h

Loading...
View Options

intern/cycles/kernel/kernel_passes.h

Loading...