Paths

Table of Contentst

Differential D12412

Texts in Outliner dont activate
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 6 2021, 4:50 PM.

Tags

Subscribers

None

Details

Reviewers

Julian Eisel (Severin)
Hans Goudey (HooglyBoogly)

Maniphest Tasks

T90862: Outliner: Wrong icon for non-py file-types

Commits

rBc33a005297ea: Texts in Outliner dont activate

Summary

Texts in Outliner dont activate on selecting (Text Editor did not change
to selected text) which is a bit inconsistent to other ID types.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 6 2021, 4:50 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B16836: Diff 41511.Sep 6 2021, 4:50 PM

Split from D12347: Fix T90862: Texts in Outliner can have wrong icon

Need to deplicate code from editsource_text_edit

Julian Eisel (Severin) added inline comments.Sep 6 2021, 4:59 PM

source/blender/editors/space_outliner/outliner_select.c
745–754	What I meant in D12347 is that this code is duplicated from `editsource_text_edit()`. But I'd rather see them share a function (`ED_text_activate_in_screen()` or so).

deduplicate code

Harbormaster completed remote builds in B16866: Diff 41565.Sep 8 2021, 11:25 AM

Philipp Oeser (lichtwerk) added a project: User Interface.Sep 8 2021, 11:26 AM

Philipp Oeser (lichtwerk) marked an inline comment as done.

Personally I think it's fine to use the biggest area. Not great (most users don't understand what's going on from what I heard), but it has become a common pattern by now.

This revision is now accepted and ready to land.Sep 29 2021, 11:21 AM

Closed by commit rBc33a005297ea: Texts in Outliner dont activate (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 29 2021, 3:12 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBc33a005297ea: Texts in Outliner dont activate.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

include/

2 lines

interface/

interface_ops.c

11 lines

space_outliner/

outliner_select.c

11 lines

space_text/

20 lines

Diff 42661

source/blender/editors/include/ED_text.h

Loading...

source/blender/editors/interface/interface_ops.c

Loading...

source/blender/editors/space_outliner/outliner_select.c

Loading...

source/blender/editors/space_text/text_draw.c

Loading...