Details

Reviewers

Commits

rBbf47fb40fd6f: Geometry Nodes: fields and anonymous attributes

Summary

This patch implements the initial core framework for fields and anonymous attributes as described on devtalk.
It was developed by Hans and me.

The two core components of this patch allow the following:

Building and evaluating fields at run-time (FN_fields.hh).
Creating and accessing anonymous attributes on geometry (BKE_anonymous_attribute.h).

For evaluating fields we use a new so called multi-function procedure (FN_multi_function_procedure.hh).
It allows composing multi-functions in arbitrary ways and supports efficient evaluation as is required by fields.
See FN_multi_function_procedure_test.cc for more details on how this evaluation mechanism can be used.

A new AttributeIDRef has been added which allows handling named and anonymous attributes in the same way in many places.

On the user level, the following has changed:

New Position node.
New Index node.
New Normal node.
New Set Position node.
New Attribute Capture node (same as Attribute Freeze in the prototype).
Socket inspection for fields is not yet working.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Sep 6 2021, 7:49 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B16841: Diff 41520.Sep 6 2021, 7:49 PM

cleanup

Harbormaster completed remote builds in B16842: Diff 41521.Sep 6 2021, 7:56 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Sep 6 2021, 8:11 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

fix exposed string socket

Harbormaster completed remote builds in B16843: Diff 41522.Sep 6 2021, 8:56 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Sep 7 2021, 12:52 AM

Hans Goudey (HooglyBoogly) added a project: Geometry Nodes.

Cleanup: Add comment about reusing span for input and output

Harbormaster completed remote builds in B16846: Diff 41530.Sep 7 2021, 3:44 AM

Merge branch 'master' into temp-geometry-nodes-fields
Remove changes to the Point Translate node

Since we were recently talking about just duplicating every node with a string input and separating the updated versions, I've removed the changes to the point translate node.

I separated the code for the "Fields" point separate node into a paste so we can apply it after renaming all of the old nodes: P2371

Harbormaster completed remote builds in B16858: Diff 41546.Sep 7 2021, 8:17 PM

Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)Sep 7 2021, 8:18 PM

Merge branch 'master' into temp-geometry-nodes-fields
A few picky changes to comments
Rename "dst_hints" to "dst_varrays", update comments
Add description for domain property

Harbormaster completed remote builds in B16872: Diff 41574.Sep 8 2021, 4:59 PM

At this point I don't have any further improvements I would make to this patch, I think it's a really nice starting point and is ready to go to master.

For the records, it looks not not much review has gone on here, but we mostly did it by simply updating the branch or discussing on chat.
I think the patch is well commented and clear, so that process shouldn't be an issue.

This revision is now accepted and ready to land.Sep 8 2021, 5:01 PM

I have no remarks with the code here (nor did I check it). But I want to propose the following merge strategy:

Hide new nodes from UI.
Merge.
Implement the draw changes for diff. flows/sockets.
Implement warning propagation for old nodes.
Hide all old nodes that will be replaced/upgraded.
Bring in new nodes (so the menu will get considerably small).
Keep bringing more new nodes.

The hiding of the new nodes can happen using an experimental flag.

The rationale is that I think we should avoid having the old and the new system co-existing more than we have to. That would leave Blender in a unreleaseble state for too long. Developing only in a branch also has its downsides.

With this approach the worst case scenario is to release 3.0 with a sub-set of the nodes. Not ideal, but acceptable.

In theory we could flip the nodes visibility (show new ones instead of old ones) after all the new ones are ready. It depends on how long we will get this done. This is a decision we can have it later too, depending on how long the other targets (draw changes, warning system) take.

Finally, as you can see from my list, I think the experience of fields should be good from the get go. People should be able to tell them apart from the nodes they are used to. The legacy node(-tree)s should be blatantly visibly different than the new one. I think this approach will bring more clarity to the users and will allow more people to test it properly from day one.

Jacques Lucke (JacquesLucke) mentioned this in T91274: Geometry Nodes Fields.Sep 9 2021, 11:33 AM

hide new nodes behind feature flag

Harbormaster completed remote builds in B16892: Diff 41605.Sep 9 2021, 11:40 AM

Hadrien Brissaud (hadrien) awarded a token.Sep 9 2021, 11:50 AM

Closed by commit rBbf47fb40fd6f: Geometry Nodes: fields and anonymous attributes (authored by Jacques Lucke (JacquesLucke)). · Explain WhySep 9 2021, 1:02 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBbf47fb40fd6f: Geometry Nodes: fields and anonymous attributes.

Damian (damian) awarded a token.Sep 9 2021, 1:39 PM

Roger Menzi (Roger_Menzi) awarded a token.Sep 9 2021, 4:07 PM

Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.Sep 14 2021, 11:56 AM

Geometry Nodes: Fields and anonymous attributes.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41610

release/scripts/startup/bl_ui/space_userpref.py

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_anonymous_attribute.h

source/blender/blenkernel/BKE_anonymous_attribute.hh

source/blender/blenkernel/BKE_attribute_access.hh

source/blender/blenkernel/BKE_customdata.h

source/blender/blenkernel/BKE_geometry_set.hh

source/blender/blenkernel/BKE_geometry_set_instances.hh

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/CMakeLists.txt

source/blender/blenkernel/intern/anonymous_attribute.cc

source/blender/blenkernel/intern/attribute_access.cc

source/blender/blenkernel/intern/attribute_access_intern.hh

source/blender/blenkernel/intern/curve_eval.cc

source/blender/blenkernel/intern/customdata.c

source/blender/blenkernel/intern/geometry_component_curve.cc

source/blender/blenkernel/intern/geometry_component_mesh.cc

source/blender/blenkernel/intern/geometry_set_instances.cc

source/blender/blenkernel/intern/node.cc

source/blender/editors/space_spreadsheet/spreadsheet_data_source_geometry.cc

source/blender/functions/CMakeLists.txt

source/blender/functions/FN_field.hh

source/blender/functions/FN_field_cpp_type.hh

source/blender/functions/FN_multi_function_builder.hh

source/blender/functions/FN_multi_function_params.hh

source/blender/functions/FN_multi_function_procedure.hh

source/blender/functions/FN_multi_function_procedure_builder.hh

source/blender/functions/FN_multi_function_procedure_executor.hh

source/blender/functions/intern/cpp_types.cc

source/blender/functions/intern/field.cc

source/blender/functions/intern/multi_function_builder.cc

source/blender/functions/intern/multi_function_procedure.cc

source/blender/functions/intern/multi_function_procedure_builder.cc

source/blender/functions/intern/multi_function_procedure_executor.cc

source/blender/functions/tests/FN_field_test.cc

source/blender/functions/tests/FN_multi_function_procedure_test.cc

source/blender/makesdna/DNA_customdata_types.h

source/blender/makesdna/DNA_node_types.h

source/blender/makesdna/DNA_userdef_types.h

source/blender/makesrna/intern/rna_nodetree.c

source/blender/makesrna/intern/rna_userdef.c

source/blender/modifiers/intern/MOD_nodes.cc

source/blender/modifiers/intern/MOD_nodes_evaluator.cc

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_geometry.h

source/blender/nodes/NOD_geometry_exec.hh

source/blender/nodes/NOD_static_types.h

source/blender/nodes/geometry/node_geometry_util.hh

source/blender/nodes/geometry/nodes/node_geo_attribute_capture.cc

source/blender/nodes/geometry/nodes/node_geo_curve_endpoints.cc

source/blender/nodes/geometry/nodes/node_geo_curve_resample.cc

source/blender/nodes/geometry/nodes/node_geo_curve_reverse.cc

source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc

source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc

source/blender/nodes/geometry/nodes/node_geo_curve_to_points.cc

source/blender/nodes/geometry/nodes/node_geo_curve_trim.cc

source/blender/nodes/geometry/nodes/node_geo_delete_geometry.cc

source/blender/nodes/geometry/nodes/node_geo_input_index.cc

source/blender/nodes/geometry/nodes/node_geo_input_normal.cc

source/blender/nodes/geometry/nodes/node_geo_input_position.cc

source/blender/nodes/geometry/nodes/node_geo_join_geometry.cc

source/blender/nodes/geometry/nodes/node_geo_mesh_to_curve.cc

source/blender/nodes/geometry/nodes/node_geo_point_distribute.cc

source/blender/nodes/geometry/nodes/node_geo_point_separate.cc

source/blender/nodes/geometry/nodes/node_geo_set_position.cc

source/blender/nodes/intern/geometry_nodes_eval_log.cc

source/blender/nodes/intern/node_socket.cc

Geometry Nodes: Fields and anonymous attributes.
ClosedPublic
Actions

Revision Contents
Changeset List