Page MenuHome
Differential D12416

Fix T91093: Off by one error in curve resample node.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Sep 7 2021, 1:26 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T91093: GeometryNodes: Resample Curve Length Error
Commits
rB73ef2fc2f4e4: Fix T91093: off by one error in when resampling curve
Summary

Example: When the length of the spline is 3 and the expected distance between two points is 1, then we need 4 points. Previously it only created 3.

Diff Detail

Repository
rB Blender
Branch
curve-resample-off-by-one (branched from master)
Build Status
Buildable 16854
Build 16854: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Sep 7 2021, 1:26 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B16852: Diff 41539.Sep 7 2021, 1:26 PM
Jacques Lucke (JacquesLucke) added a task: T91093: GeometryNodes: Resample Curve Length Error.Sep 7 2021, 1:27 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) accepted this revision.Sep 7 2021, 3:35 PM

Thanks for the fix. I guess int( does a floor operation, I probably should have known that. Using ceil first seems to also fix the issue for me.

For some reason (probably not using that explicit "int" conversion, the curve to points node doesn't need the same fix

This revision is now accepted and ready to land.Sep 7 2021, 3:35 PM
Hans Goudey (HooglyBoogly) added a comment.Sep 7 2021, 3:53 PM

I was wrong about that, it doesn't have the same behavior, and curve to points does need the same fix.

Jacques Lucke (JacquesLucke) updated this revision to Diff 41541.Sep 7 2021, 4:00 PM
  • also fix curve to points node
Harbormaster completed remote builds in B16854: Diff 41541.Sep 7 2021, 4:00 PM
Hans Goudey (HooglyBoogly) accepted this revision.Sep 7 2021, 4:04 PM
Closed by commit rB73ef2fc2f4e4: Fix T91093: off by one error in when resampling curve (authored by Jacques Lucke (JacquesLucke)). · Explain WhySep 7 2021, 4:08 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB73ef2fc2f4e4: Fix T91093: off by one error in when resampling curve.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
2 lines
2 lines

Diff 41541

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_resample.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_curve_to_points.cc

Loading...