Fix T89514: GP draw mode not saved when scene is not the active one
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Sep 7 2021, 7:05 PM.

Details

Reviewers

Antonio Vazquez (antoniov)

Maniphest Tasks

T89514: GPencil: Draw mode not saved when scene is not the active one

Commits

rBe9150ac3176e: Fix T89514: GP draw mode not saved when scene is not the active one

Summary

This patch fixes the error that pops up
(Error: Unable to execute '... Mode Toggle', error changing modes)
when trying to switch to e.g. draw mode from a grease pencil object
that was saved in draw mode in an inactive scene when the file was loaded.

Note that this does not fix the bigger issue described in T91243.

The fix makes sure that we reset all the mode flags on the grease pencil
data when we set the mode to object mode.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 16857
Build 16857: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Sep 7 2021, 7:05 PM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B16857: Diff 41545.Sep 7 2021, 7:05 PM

Falk David (filedescriptor) added a task: T89514: GPencil: Draw mode not saved when scene is not the active one.Sep 7 2021, 7:09 PM

I think the fix is correct because the mode flag is in the datablock too (some places is impossible get the mode from object, so we keep a backup of the data). Your fix disable all modes and keep the datablock as Object mode.

Antonio Vazquez (antoniov) accepted this revision.Sep 7 2021, 8:16 PM

Antonio Vazquez (antoniov) added a reviewer: Antonio Vazquez (antoniov).

This revision is now accepted and ready to land.Sep 7 2021, 8:17 PM

@Falk David (filedescriptor) you have this patch ready since September, is it still valid?