Page MenuHome

Fix T91285: Erroneous tooltip for "Slip Strip Contents" menu operator
ClosedPublic

Authored by Pratik Borhade (PratikPB2123) on Sep 10 2021, 5:47 AM.

Details

Summary

Fix T91285.

This patch is created to change the tooltip for Slip Strip Contents
As per the present info, only active strip will be affected.
But in reality selected strips can be trimmed with this operator.

Word Trim changed to Slip in tooltip

Diff Detail

Repository
rB Blender

Event Timeline

Hi @Richard Antalik (ISS) , would you like to review this small patch? :)

This revision is now accepted and ready to land.Sep 10 2021, 6:12 AM

While this is being looked at, the word "Trim" is also incorrect, it should be Slip instead.
Trimming is changing the duration of a strip, by altering the in or out point.
Slip doesn't change the duration, but the content of the strip.

The mistake was introduced here: https://developer.blender.org/rBf95241eb3e76fc208a260200c873b43849e165ac
And attempted to be corrected here: https://developer.blender.org/rB179ad7dcba950c51dcb9726dc2350ff799780cc6
...but apparently not all was correctly renamed. Imo, that should be done now.

Perhaps it is good idea to change also word Trim to Slip since it is used everywhere? Seems we don't use word trim anywhere else, so slip is more accurate?

Word Trim changed to Slip in tooltip

Hi, can someone commit this if the patch is fine? :)

Campbell Barton and Richard Antalik ^

Hi, can someone commit this if the patch is fine? :)

Campbell Barton and Richard Antalik ^

Yes, it is. I think you don't have commit rights? I can push to master in such case.