VSE: Rename Expand to Insert
AbandonedPublic
Actions

Authored by Peter Fog (tintwotin) on Sep 12 2021, 8:43 AM.

Details

Reviewers

Francesco Siddi (fsiddi)
Richard Antalik (ISS)

Summary

As mentioned in D11805#320368, this patch renames Expand to industry standard Insert.
Reference: https://kdenlive.org/en/video-editing-applications-handbook/

Also, update tooltips for clarity and consistency.

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Sep 12 2021, 8:43 AM

Peter Fog (tintwotin) created this revision.

I have no objection to this, just a couple of questions:

Did you check with the original author of the code on why this is currently called "Expand"?
Can you confirm that you will update the user manual to reflect the change?

In D12461#326169, @Francesco Siddi (fsiddi) wrote:

I have no objection to this, just a couple of questions:

Did you check with the original author of the code on why this is currently called "Expand"?

The code is that old and refactored since it was committed so it is not possible (for me) to see who committed this. Maybe @Antonis Ryakiotakis (psy-fi) can answer your question?

Can you confirm that you will update the user manual to reflect the change?

I can confirm that I'll reach out to those who know how to do this, if this gets committed ever .

This patch didn't make it into 3.0. As I do not have anymore time or motivation for a continued investment in the Blender project, I'm giving up on this patch for now.