VSE UI: Move Movie and Image sub menus into sidebar since they are for the active strip
AbandonedPublic
Actions

Authored by Peter Fog (tintwotin) on Sep 12 2021, 1:43 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Richard Antalik (ISS)
Francesco Siddi (fsiddi)
Hans Goudey (HooglyBoogly)
Campbell Barton (campbellbarton)

Summary

In relation to: T91306 this patch will move Movie(Set Render Size + Deinterlace(was already exposed in sidebar)) and Image(Set Render Size + Separate Images) menu entries into the strip source sidebar, since they are working on the active strip, but can batch change with +alt or Copy to Selected in consistency with the other properties in the active strip sidebar.

Also, the strip specific menus are not noticed by users, since they are only visible when the active strip is the specific file type. This concept doesn't work.

Movie Menu:

Image "Menu":

Set Render Size has been changed to the more informative Set output Aspect and Resolution because there is room for that.

FPS has been renamed Frame Rate in consistency with Render settings.

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Sep 12 2021, 1:43 PM

Peter Fog (tintwotin) created this revision.

Peter Fog (tintwotin) mentioned this in T91306: VSE: Ensure all operators in the Strip menu are working on the selected and not only on active strip (+unselected) .Sep 12 2021, 1:47 PM

Image separate operates on selected strips, so that part of the patch should be removed.

Further, I think we might consider a rule of thumb for moving menu items into panels, simply doing this for any action that operates on the active item might not be ideal (if we did this for object mode menu items it has wider implications).

This revision now requires changes to proceed.Sep 13 2021, 12:21 PM

In D12464#324954, @Campbell Barton (campbellbarton) wrote:

Image separate operates on selected strips, so that part of the patch should be removed.

Further, I think we might consider a rule of thumb for moving menu items into panels, simply doing this for any action that operates on the active item might not be ideal (if we did this for object mode menu items it has wider implications).

I also wrote above:

Also, the strip specific menus are not noticed by users, since they are only visible when the active strip is the specific file type. This concept doesn't work.

Separating Images is actually changing the source material from image sequence to single strips, so looking for it under the Source would be a natural thing to do.

I guess Separate Images could be changed to work on the active strip and +alt for selected like the other functions in the Strip sidebar?

As a rule of thumb, operators should not be moved in the properties panel, or mixed with them.
There might be some exceptions, but this is not the case.

@Francesco Siddi (fsiddi) Ok, separate images stays, and will only show up when a image/image-sequence is the active strip. Deinterlace is already exposed in both the menu and the sidebar, do you still want it exposed both places? And what about Set Render Size, where do you want it? Sidebar, Menu or both?

Nb. this is part of a larger clean up of active-strip-only functions, so you might take a look at the others as well: https://developer.blender.org/T91306

Peter Fog (tintwotin) requested review of this revision.Sep 20 2021, 10:49 PM

This patch didn't make it into 3.0. As I do not have anymore time or motivation for a continued investment in the Blender project, I'm giving up on this patch for now.