Page MenuHome
Differential D12473

Support flipping sides in mesh bisect
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 13 2021, 3:57 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T91320: Bisect straight line gesture features dont work ("Flip" / "Snap" option)
Commits
rB1bcdd1c54e6e: Fix T91320: Support flipping sides in mesh bisect
Summary

Changing active side was introduced in rB7ff6bfd1e0af: UI: Allow changing the active side of line gestures but was never
working for tools/operators other than the sculpt line mask tool.

While for most tools/operators this actually does not make sense, the
bisect operator can actually benefit from it.

thx @Campbell Barton (campbellbarton) for additional input!

Diff Detail

Repository
rB Blender
Branch
T91320_b (branched from master)
Build Status
Buildable 16974
Build 16974: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Sep 13 2021, 3:57 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B16970: Diff 41749.Sep 13 2021, 3:57 PM
Philipp Oeser (lichtwerk) added a project: Modeling.Sep 13 2021, 4:00 PM
Campbell Barton (campbellbarton) accepted this revision.Sep 13 2021, 4:03 PM
This revision is now accepted and ready to land.Sep 13 2021, 4:03 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 41751.Sep 13 2021, 4:06 PM

only support flipping if we are clearing either side

Harbormaster completed remote builds in B16972: Diff 41751.Sep 13 2021, 4:06 PM
Campbell Barton (campbellbarton) added inline comments.Sep 13 2021, 4:11 PM
source/blender/editors/mesh/editmesh_bisect.c
151

clear_inner != clear_outer - since if both are true, the side doesn't matter.

if ((clear_inner != clear_outer) || fill) {...}

Philipp Oeser (lichtwerk) updated this revision to Diff 41754.Sep 13 2021, 4:23 PM

improve condition for when to use flipping

Harbormaster completed remote builds in B16974: Diff 41754.Sep 13 2021, 4:23 PM
Philipp Oeser (lichtwerk) marked an inline comment as done.Sep 13 2021, 4:24 PM
Campbell Barton (campbellbarton) accepted this revision.Sep 13 2021, 4:24 PM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Sep 13 2021, 4:25 PM
Closed by commit rB1bcdd1c54e6e: Fix T91320: Support flipping sides in mesh bisect (authored by Philipp Oeser (lichtwerk)). · Explain WhySep 13 2021, 4:43 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB1bcdd1c54e6e: Fix T91320: Support flipping sides in mesh bisect.
Damian (damian) awarded a token.Sep 13 2021, 5:27 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
17 lines
windowmanager/
intern/
3 lines

Diff 41754

View Options

source/blender/editors/mesh/editmesh_bisect.c

Loading...
View Options

source/blender/windowmanager/intern/wm_gesture_ops.c

Loading...