Page MenuHome

FBX export: Default to PERFMON disabled
ClosedPublic

Authored by Martin Preisler (mpreisler) on Sep 13 2021, 7:24 PM.

Details

Summary

The perfmon class spams stdout, this is not a big deal for GUI usage of Blender but makes CLI/automation use-cases difficult. We export many blend files to FBX as part of our pipeline and this makes our logs unreadable.

Example of output when exporting FBX file from Blender with PERFMON enabled:

FBX export prepare: Wrapping Objects...
	Done (0.000028 sec)
FBX export prepare: Wrapping Data (lamps, cameras, empties)...
	Done (0.000014 sec)
FBX export prepare: Wrapping Meshes...
	Done (0.000022 sec)
FBX export prepare: Wrapping ShapeKeys...
	Done (0.000008 sec)
FBX export prepare: Wrapping Armatures...
	Done (0.000013 sec)
FBX export prepare: Wrapping World...
	Done (0.000011 sec)
FBX export prepare: Wrapping Materials...
	Done (0.000014 sec)
FBX export prepare: Wrapping Textures...
	Done (0.000235 sec)
FBX export prepare: Wrapping Animations...
	Done (0.000011 sec)
FBX export prepare: Generating templates...
	Done (0.000029 sec)
FBX export prepare: Generating Connections...
	Done (0.000040 sec)
FBX export fetch empties (0)...
	Done (0.000007 sec)
FBX export fetch lamps (0)...
	Done (0.000008 sec)
FBX export fetch cameras (0)...
	Done (0.000008 sec)
FBX export fetch meshes (1)...
	Done (1.570453 sec)
FBX export fetch objects (1)...
	Done (0.000220 sec)
FBX export fetch remaining...
	Done (0.001314 sec)
FBX export fetch animations...
	Done (0.000016 sec)
export finished in 1.5777 sec.

Diff Detail

Event Timeline

Martin Preisler (mpreisler) requested review of this revision.Sep 13 2021, 7:24 PM
Martin Preisler (mpreisler) created this revision.

@Bastien Montagne (mont29) IIRC you added this, disabling seems fine, this could also use a short comment explaining what it does.

This revision is now accepted and ready to land.Sep 14 2021, 3:14 AM

This is probably a super noob question but how do I actually land this? I worked with arcanist and phabricator before but in those cases I had rights to land which I probably don't have here. I read various guides but can't find how to do that.

Would it be possible to pick this up for 2.83 LTS because it's a low risk change?

Note that while this patch is accepted, the body of the patch isn't formatted well for a commit message, https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

This should be updated before landing this patch.

I also wanted feedback from mont29, adding as blockging reviewer.


Note that I personally don't use arc land, however if you try this use --hold so you can review the change locally before pushing.

This revision now requires review to proceed.Sep 15 2021, 11:25 AM

Am fine with disabling that by default yes. No real time to do it properly right now though. @Campbell Barton (campbellbarton) feel free to do on if you want, otherwise I'll tackle these sort of things after BCon2 I think

This revision is now accepted and ready to land.Sep 16 2021, 10:00 AM