Page MenuHome

Cleanup: Extract keyframe filter from graph_slider_ops
ClosedPublic

Authored by Christoph Lendenfeld (ChrisLend) on Sep 14 2021, 9:36 PM.

Details

Summary

The anim_filter is an int flag that was duplicated across the graph_slider_ops file.
Since the plan is to extend this file with other functions using this filter, it makes sense to have it in a single location

Creates a new constant OPERATOR_DATA_FILTER

No functional changes

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) requested changes to this revision.Sep 16 2021, 10:23 AM

It's a good idea to centralise the definition of the filter. However, now that the definition of this filter is moved further away from its use, the reader has less contextual information about it. It would help to get a comment that explains what the filter is used for.

Maybe once that's described, we can think of a less generic term than just "anim filter", one that expresses its purpose rather than just its contents.

This revision now requires changes to proceed.Sep 16 2021, 10:23 AM
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)

rename ANIM_FILTER to OPERATOR_DATA_FILTER

This revision is now accepted and ready to land.Oct 29 2021, 11:40 AM