Page MenuHome

Geometry Nodes: Add special domain interpolation for selections
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Sep 14 2021, 9:43 PM.

Details

Summary

The generic domain interpolation algorithms didn't quite work for
selections. The interpolation would do unexpected things that
were different than the results in edit mode. The new behavior
is supposed to be the same as edit mode, although we also have
to handle face corner selections here.

Currently the code assumes that all boolean attributes should be
handled that way. I'm not sure of why that wouldn't be the case.

Diff Detail

Repository
rB Blender
Branch
geometry-nodes-interpolate-selection (branched from master)
Build Status
Buildable 17014
Build 17014: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 14 2021, 9:43 PM
Hans Goudey (HooglyBoogly) created this revision.
source/blender/blenkernel/intern/geometry_component_mesh.cc
356

r_values hasn't been initialized.

Hans Goudey (HooglyBoogly) marked an inline comment as done.
  • Fix unininitialized array values used

The commit message should say that if the need for non-selection bool attributes comes up, it could be supported as well.

This revision is now accepted and ready to land.Sep 15 2021, 2:42 PM