Page MenuHome
Differential D12489

Cleanup: move code in graph_slider_ops
ClosedPublic
Actions

Authored by Christoph Lendenfeld (ChrisLend) on Sep 14 2021, 9:45 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Maniphest Tasks
T81785: Implementation: Modal Key Manipulation Operators
Commits
rB3364a5bea6c9: Cleanup: move code in graph_slider_ops
Summary

Future operators can use the code, so it is moved up to disassociate it from decimate

No functional changes

Diff Detail

Repository
rB Blender

Event Timeline

Christoph Lendenfeld (ChrisLend) requested review of this revision.Sep 14 2021, 9:45 PM
Christoph Lendenfeld (ChrisLend) created this revision.
Christoph Lendenfeld (ChrisLend) mentioned this in D12490: Cleanup: renames in graph_slider_ops.Sep 14 2021, 9:50 PM
Christoph Lendenfeld (ChrisLend) added a child revision: D12490: Cleanup: renames in graph_slider_ops.
Christoph Lendenfeld (ChrisLend) mentioned this in D9317: Extract functions from GRAPH_OT_decimate.Sep 14 2021, 9:56 PM
Christoph Lendenfeld (ChrisLend) mentioned this in T81785: Implementation: Modal Key Manipulation Operators.
Christoph Lendenfeld (ChrisLend) added a task: T81785: Implementation: Modal Key Manipulation Operators.
Sybren A. Stüvel (sybren) edited reviewers, added: Sybren A. Stüvel (sybren); removed: Animation & Rigging.Sep 16 2021, 11:11 AM
Sybren A. Stüvel (sybren) accepted this revision.Sep 16 2021, 11:17 AM

👍 on the separation of moving the code & renaming things.

IMO the patches could be done in the opposite order: first rename to more generic names, then move the renamed code to the proper location. Now I was a bit confused about "moving to disassociate from decimate" and seeing a struct tDecimateGraphOp being moved into the part of the file that was supposed to be non-decimate.

No need to re-submit for review, just commit in the opposite order (D12490 before D12489).

This revision is now accepted and ready to land.Sep 16 2021, 11:17 AM
Christoph Lendenfeld (ChrisLend) updated this revision to Diff 44180.Oct 31 2021, 11:08 PM
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)

Redo patches so rename happens before move

Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)Oct 31 2021, 11:09 PM
Christoph Lendenfeld (ChrisLend) removed a child revision: D12490: Cleanup: renames in graph_slider_ops.
Christoph Lendenfeld (ChrisLend) removed a parent revision: D12487: Cleanup: Extract function to store bezt arrays.
Closed by commit rB3364a5bea6c9: Cleanup: move code in graph_slider_ops (authored by Christoph Lendenfeld (ChrisLend)). · Explain WhyNov 4 2021, 10:35 PM
This revision was automatically updated to reflect the committed changes.
Christoph Lendenfeld (ChrisLend) added a commit: rB3364a5bea6c9: Cleanup: move code in graph_slider_ops.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_graph/
68 lines

Diff 44392

View Options

source/blender/editors/space_graph/graph_slider_ops.c

Loading...