Page MenuHome
Differential D12490

Cleanup: renames in graph_slider_ops
ClosedPublic
Actions

Authored by Christoph Lendenfeld (ChrisLend) on Sep 14 2021, 9:49 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Maniphest Tasks
T81785: Implementation: Modal Key Manipulation Operators
Commits
rB6986b43b3d2d: Cleanup: renames in graph_slider_ops
Summary

This patch renames:

  • tDecimateGraphOp to tGraphSliderOp
  • dgo to gso (to match with the struct rename)
  • decimate_reset_bezts to reset_bezts to indicate it can be used by other functions

No functional changes

Diff Detail

Repository
rB Blender

Event Timeline

Christoph Lendenfeld (ChrisLend) requested review of this revision.Sep 14 2021, 9:49 PM
Christoph Lendenfeld (ChrisLend) created this revision.
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)
Christoph Lendenfeld (ChrisLend) added a parent revision: D12489: Cleanup: move code in graph_slider_ops.
Christoph Lendenfeld (ChrisLend) mentioned this in D9317: Extract functions from GRAPH_OT_decimate.Sep 14 2021, 9:56 PM
Christoph Lendenfeld (ChrisLend) mentioned this in T81785: Implementation: Modal Key Manipulation Operators.
Christoph Lendenfeld (ChrisLend) added a task: T81785: Implementation: Modal Key Manipulation Operators.
Sybren A. Stüvel (sybren) edited reviewers, added: Sybren A. Stüvel (sybren); removed: Animation & Rigging.Sep 16 2021, 11:11 AM
Sybren A. Stüvel (sybren) accepted this revision.Sep 16 2021, 11:17 AM
Sybren A. Stüvel (sybren) mentioned this in D12489: Cleanup: move code in graph_slider_ops.

LGTM, nice work, but do see my note about commit order in D12489.

This revision is now accepted and ready to land.Sep 16 2021, 11:18 AM
Christoph Lendenfeld (ChrisLend) updated this revision to Diff 44178.Oct 31 2021, 11:06 PM
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)

Reorder patches so renaming happens before moving code

Christoph Lendenfeld (ChrisLend) removed a parent revision: D12489: Cleanup: move code in graph_slider_ops.Oct 31 2021, 11:10 PM
Closed by commit rB6986b43b3d2d: Cleanup: renames in graph_slider_ops (authored by Christoph Lendenfeld (ChrisLend)). · Explain WhyNov 4 2021, 10:20 PM
This revision was automatically updated to reflect the committed changes.
Christoph Lendenfeld (ChrisLend) added a commit: rB6986b43b3d2d: Cleanup: renames in graph_slider_ops.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_graph/
92 lines

Diff 44391

View Options

source/blender/editors/space_graph/graph_slider_ops.c

Loading...