Fix T81922: Pose bones don't show in the graph editor when it's object isn't selected
ClosedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Sep 15 2021, 8:20 AM.

Details

Reviewers

Maniphest Tasks

T81922: The Graph Editor doesn't show any curve of the Armature (if in Pose mode, but armature unselected, with box/circle/lasso tools)

Summary

Whilst in pose-mode, the selection filter only includes other objects in pose-mode instead of the object selection.

This makes sense as the selection of the pose bones what the user as acting on in the 3D view.
The object selection only makes sense to use in object mode.

Diff Detail

Repository

rB Blender

Branch

TEMP-T81922-FIX (branched from master)

Build Status

Buildable 17023
Build 17023: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Sep 15 2021, 8:20 AM

Campbell Barton (campbellbarton) created this revision.

Harbormaster completed remote builds in B17022: Diff 41838.Sep 15 2021, 8:20 AM

Campbell Barton (campbellbarton) mentioned this in T81922: The Graph Editor doesn't show any curve of the Armature (if in Pose mode, but armature unselected, with box/circle/lasso tools).Sep 15 2021, 8:31 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Sep 15 2021, 8:36 AM

Campbell Barton (campbellbarton) added a reviewer: Sybren A. Stüvel (sybren).

Campbell Barton (campbellbarton) added a project: Animation & Rigging.

Improve code-comment

Harbormaster completed remote builds in B17023: Diff 41840.Sep 15 2021, 8:43 AM

Campbell Barton (campbellbarton) edited tasks, added T81922: The Graph Editor doesn't show any curve of the Armature (if in Pose mode, but armature unselected, with box/circle/lasso tools); removed T90156: VSE image transformation in preview.Sep 15 2021, 9:07 AM

Restrict this behavior to pose-mode.

Harbormaster completed remote builds in B17026: Diff 41847.Sep 15 2021, 11:07 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)Sep 27 2021, 11:02 AM

Campbell Barton (campbellbarton) edited the summary of this revision. (Show Details)

Sybren A. Stüvel (sybren) accepted this revision.Sep 27 2021, 11:05 AM

This revision is now accepted and ready to land.Sep 27 2021, 11:05 AM

Campbell Barton (campbellbarton) mentioned this in rB2c2e1b3d612d: Fix T81922: Pose bones F-Curves hidden for unselected objects.Sep 27 2021, 1:05 PM

Campbell Barton (campbellbarton) closed this revision.Sep 27 2021, 1:06 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

animation/

anim_filter.c

31 lines

Diff 41840

View Options

source/blender/editors/animation/anim_filter.c

Fix T81922: Pose bones don't show in the graph editor when it's object isn't selectedClosedPublicActions