UI: Remove Menus & Show Wait Cursor When Saving
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Sep 16 2021, 2:14 AM.

Details

Reviewers

Campbell Barton (campbellbarton)

Group Reviewers

User Interface

Commits

rB7a9cfd08a8d7: UI: Remove Menus & Show Wait Cursor When Saving

Summary

When saving blend files close any menus that might be open, show
"waiting" mouse cursor right away, before creating preview.

When you select "Save" from the File menu that menu will remain open until the saving process is complete, which can make blender look temporarily broken. This patch closes any open menus early in the saving process. Saving also currently sets and unset a "waiting" mouse cursor, but doesn't start this until after thumbnail creation. This patch moves that to before this happens so the wait cursor is shown during that part of the process to.

Because of these changes are to the greater process of saving, this patch also removes similar calls inside blend_file_thumb_from_screenshot since that is inside the parent the process.

Diff Detail

Repository: rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Sep 16 2021, 2:14 AM

Harley Acheson (harley) created this revision.

Minor request, otherwise LGTM (no additional review passes needed).

source/blender/windowmanager/intern/wm_files.c
1759	Better check `!G.background`. NOTE: ifdef checks make code harder to maintain. It makes sense if this is checking for a resource not available in headless mode, or there is some significant gain. In this case though, I think it makes more sense to check `G.background`.