Page MenuHome
Differential D12508

EEVEE fix gloss low roughness error
ClosedPublic
Actions

Authored by Jake (Welp) on Sep 16 2021, 3:59 AM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T88754: Intel HD graphics: Changing Roughness Value to 0 causes mesh to be black
Commits
rB651f1b5cf9f6: EEVEE fix gloss low roughness error
rB4c156cba21f7: EEVEE fix gloss low roughness error
Summary

Up lower clamp on spec_angle to prevent NaN from being generated on intel GPUs at low roughness.

Fixes T88754

Diff Detail

Repository
rB Blender
Branch
Intel-EEVEE-fix (branched from master)
Build Status
Buildable 17043
Build 17043: arc lint + arc unit

Event Timeline

Jake (Welp) requested review of this revision.Sep 16 2021, 3:59 AM
Jake (Welp) created this revision.
Harbormaster completed remote builds in B17043: Diff 41885.Sep 16 2021, 3:59 AM
Jake (Welp) added a reviewer: Clément Foucault (fclem).Sep 16 2021, 4:02 AM
Clément Foucault (fclem) accepted this revision.Sep 16 2021, 8:58 AM
This revision is now accepted and ready to land.Sep 16 2021, 8:58 AM
Closed by commit rB4c156cba21f7: EEVEE fix gloss low roughness error (authored by • HaydenBerkson (Jake), committed by Jeroen Bakker (jbakker)). · Explain WhySep 22 2021, 8:22 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB4c156cba21f7: EEVEE fix gloss low roughness error.
Jeroen Bakker (jbakker) added a commit: rB651f1b5cf9f6: EEVEE fix gloss low roughness error.Sep 22 2021, 8:50 AM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
eevee/
shaders/
2 lines

Diff 41885

View Options

source/blender/draw/engines/eevee/shaders/ambient_occlusion_lib.glsl

Loading...