Page MenuHome
Differential D12515

Fix persistent data not allowing to change sample count and time limit
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Sep 16 2021, 3:40 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
William Leeson (leesonw)
Thomas Dinges (dingto)
Commits
rBe597e6aab28d: Fix persistent data not allowing to change sample count and time limit
Summary

The root cause was that session->params were never updated to the new
parameters.

Made it so session->reset() will make sure the session is fully up to
date with the desired parameters.

Investigation by @Thomas Dinges (dingto), code by self.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Sep 16 2021, 3:40 PM
Sergey Sharybin (sergey) created this revision.
Harbormaster completed remote builds in B17054: Diff 41900.Sep 16 2021, 3:40 PM
Thomas Dinges (dingto) accepted this revision.Sep 16 2021, 3:46 PM

Thanks for the code work, tested it and it works as expected. Samples and Time Limit are now properly updated when Persistent Data is used. This fixes T91429.

This revision is now accepted and ready to land.Sep 16 2021, 3:46 PM
HEYPictures (HEYPictures) awarded a token.Sep 16 2021, 5:11 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 16 2021, 5:49 PM
Alaska (Alaska) awarded a token.Sep 17 2021, 2:18 AM
Closed by commit rBe597e6aab28d: Fix persistent data not allowing to change sample count and time limit (authored by Sergey Sharybin (sergey)). · Explain WhySep 17 2021, 10:44 AM
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rBe597e6aab28d: Fix persistent data not allowing to change sample count and time limit.

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
59 lines
render/
6 lines
15 lines

Diff 41972

View Options

intern/cycles/blender/blender_session.cpp

Loading...
View Options

intern/cycles/render/session.h

Loading...
View Options

intern/cycles/render/session.cpp

Loading...